From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37A026ED45; Tue, 7 Apr 2026 09:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775555462; cv=none; b=ZyrrcP9pYo5Nt2r4c9gBWQVsci8UK2OyXwkhEedQ/0opAS3lsE2EtmEmsgK4U1U39kG8GZeaZA7fjNsgUQ+rUXdX5FCxhtpVCAq1iNw3vIcPHMfJpJvWD6pI77zaxKgt++5h8omEC5KYn1liNnPcvATFWHB0/2G4gD9Zlhl9Zp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775555462; c=relaxed/simple; bh=COBonQwgb/gK4C6C/EEwkyWeOJpDIt851YEdPsJchWc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eBHXX7X/PzqAErIOua7qbz98ltxkhOjvQDSCLvTCK9a4vARLX2McQh/p8nO9s+D853+uoZCxs4ea8ODdVOC3nq4lz8oSGCqDIA3kcUwaE47wDZuT3TPaYf+PU0e5Y4HmR00f7ZH1rKDl9m8XasVm0tezVIlGCgwpBQxBeLapjDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TwV7kErf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TwV7kErf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FCACC116C6; Tue, 7 Apr 2026 09:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775555461; bh=COBonQwgb/gK4C6C/EEwkyWeOJpDIt851YEdPsJchWc=; h=From:To:Cc:Subject:Date:From; b=TwV7kErfDJv1Zx54hPQCCl3r1CrLafXRpfCHq4nBCekRi3zwBXDAdX2vFmFsuDJB3 pL+3LFskq5YALaaAUSBbIxGPOcj6lSYtU5Nu5oJF5aM+jN0+YYaQKnqwcaTjbHA57z ZlcL56Rc/g278mnpV0tzZU3pxsc5tjvE4CpS8yhAjxYL4G1UWgaNFScM/K2atZ79+X XisU2M6r+p4TcYDhVf/kp+5uSc3hLcwNGHxUxTpWSkOsMAEh3YJv79wU+euC4+76FX PS+jBEh5h9Eks4y/l3z/hg3DB2yjmj5WfwVXnVcShraT3vwRgOYktteONgSMk6iNMe OQxKCstbmeipA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA35H-0000000B11r-1QAQ; Tue, 07 Apr 2026 11:50:59 +0200 From: Johan Hovold To: Stephen Boyd Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Sebastian Reichel Subject: [PATCH] clk: rk808: fix OF node reference imbalance Date: Tue, 7 Apr 2026 11:50:27 +0200 Message-ID: <20260407095027.2625516-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: 2dc51ca822e4 ("clk: RK808: Reduce 'struct rk808' usage") Cc: stable@vger.kernel.org # 6.5 Cc: Sebastian Reichel Signed-off-by: Johan Hovold --- drivers/clk/clk-rk808.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c index f7412b137e5e..5a75b5c91555 100644 --- a/drivers/clk/clk-rk808.c +++ b/drivers/clk/clk-rk808.c @@ -153,7 +153,7 @@ static int rk808_clkout_probe(struct platform_device *pdev) struct rk808_clkout *rk808_clkout; int ret; - dev->of_node = pdev->dev.parent->of_node; + device_set_of_node_from_dev(dev, dev->parent); rk808_clkout = devm_kzalloc(dev, sizeof(*rk808_clkout), GFP_KERNEL); -- 2.52.0