From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF2613ACA43; Tue, 7 Apr 2026 12:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775565232; cv=none; b=uAZrGd6rri2vLpznqe0fHLzfiDxaPjW5UFd5rnCBdLbgC51N5l5fVO76HiXaKgGiVArKkaTIRbl0d6ouvM3WjsLgAnv8KtNgmknKv+ojeEzSfMBUHBSgScugxB4SVEo9kGU2bm8rO4KRI5GcLgdaeICJpO91CtUDHKO0t8QdCgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775565232; c=relaxed/simple; bh=FwBXecI0p0IB6IN7GC8Y7FHX3sFO5EIumD+xwZduELA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TGi4NJ/gwCvz7LxxNERQMY3tmLnuUsvzJQX5xOwgGuicVmaYAGudpxGFPTQNqFkgJATyxgdi7spskcG/7qmoSPsKBUudY+WP8c4NKlsyY21CCO5m2nQhu89pGcgQC1u5jSVAF6Lo5KyMRFl9od6VZYOYN4POlREeHutcSUK8tKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IZwXHnkl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IZwXHnkl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D990C116C6; Tue, 7 Apr 2026 12:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775565231; bh=FwBXecI0p0IB6IN7GC8Y7FHX3sFO5EIumD+xwZduELA=; h=From:To:Cc:Subject:Date:From; b=IZwXHnklLNiv72pNVROTtcy/QZDXZwGibnicT5xsE7QxHoGgI5c1aBdBqbdjD85SL qUBHEL5zA6LbM/hNe9nfo3y61DI6TFhRpkmIxgrujrr2E9fTFAGwUnUXT8NrE79Ahf CLUliHMKZ6Zhz8pLiSBmLWCBlyKW5YkVtgYMflJT08UzCTwwOj+POCZmNQ5P7PCExR 3PaSgEZvP55UUHquqjLM1zB2xRp/RPs6peIxzQdrdvAQANcH6jVzFXzaePi1UCuna4 sZ5oW9AQQtdGfgLi90zrkma+Pt0zh5mTIJtFK2T8UubVWq0kDOzyZinxQxWBpNY1s8 BGPQHA+jR4bbQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA5cq-0000000BEVn-3jno; Tue, 07 Apr 2026 14:33:48 +0200 From: Johan Hovold To: Sebastian Reichel Cc: Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Dzmitry Sankouski Subject: [PATCH v2] power: supply: max17042: fix OF node reference imbalance Date: Tue, 7 Apr 2026 14:33:38 +0200 Message-ID: <20260407123338.2677375-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: 0cd4f1f77ad4 ("power: supply: max17042: add platform driver variant") Cc: stable@vger.kernel.org # 6.14 Cc: Dzmitry Sankouski Signed-off-by: Johan Hovold --- Changes in v2: - add missing driver name to patch summary prefix drivers/power/supply/max17042_battery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c index acea176101fa..914f18ce79b3 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -1165,7 +1165,8 @@ static int max17042_platform_probe(struct platform_device *pdev) if (!i2c) return -EINVAL; - dev->of_node = dev->parent->of_node; + device_set_of_node_from_dev(dev, dev->parent); + id = platform_get_device_id(pdev); irq = platform_get_irq(pdev, 0); -- 2.52.0