From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00CD3B38A0; Tue, 7 Apr 2026 12:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566133; cv=none; b=WjYL0kiaSjyUZLV2bHdaKlQL4e/zVXMtBlSjBblY2iTAShjWBeC/tcJWDdpX3wWmT3qSn9EWRqRNTyXcQOh3wGl2lNGBMSy5ZaNdaDv/dxym3sCHevx+4jbcTY7PQCrXWRvk5mhNKG6Smyo0nIUC2uH2y7DQQBjbpMIK+oZF3Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566133; c=relaxed/simple; bh=vWCNuhUoewsighVgd5hZe21pawPiAvd2Jv9BdMisxM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ovFeNB52LP1HSfXkRSAesYETg9mcutLEbEch0nx1y7icCedLX/AtSt2lQ7dFnVxFOG0q1CoTTfcpjZl14f6MWNn+CSgztWuOR+ljvat2VTFgY7AqigVK8UKTJmUUBhR5z6193J+rGWlVoAww2V6UuZGhtqcmVMJINzXnPog0NKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D+deckva; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D+deckva" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0D1DC116C6; Tue, 7 Apr 2026 12:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775566132; bh=vWCNuhUoewsighVgd5hZe21pawPiAvd2Jv9BdMisxM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D+deckvaRb6p0GV93gFF1SamlsXNEE4aHkc9T6eRuH95fYuGEJloOEqaWmGDy/VC+ TdeUXlXheeXbNuWfeaeDahoMvG4TzABaSWaHId3zIrmtGXz1Ndl/q1fI+t1M2/U91j tYJlFePb06Sf0yxYEIPPfyplhh8ruIdz7QnwNtzM8Jo/MU3sWL03dd/I2MfFdDsmrz 2t4JxPShIvxckDT1sJo/mVz/EXrn3qfB+SONsYGqiwx97CkyinSls9gn3Y0gXUK4Tn nFAMyY7j8sb9LT0DyIzr4sU8Zrm7p8AYIoG5uom5DCRNES2vjmHvybf5KnpgQnc4g7 EZBfe3xRKoH5w== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA5rO-0000000BHeR-26CI; Tue, 07 Apr 2026 14:48:50 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Marek Vasut , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Wenyou Yang Subject: [PATCH 1/2] regulator: act8945a: fix OF node reference imbalance Date: Tue, 7 Apr 2026 14:48:35 +0200 Message-ID: <20260407124836.2689436-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260407124836.2689436-1-johan@kernel.org> References: <20260407124836.2689436-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: 38c09961048b ("regulator: act8945a: add regulator driver for ACT8945A") Cc: stable@vger.kernel.org # 4.6 Cc: Wenyou Yang Signed-off-by: Johan Hovold --- drivers/regulator/act8945a-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c index 24cbdd833863..5bbe2bce740e 100644 --- a/drivers/regulator/act8945a-regulator.c +++ b/drivers/regulator/act8945a-regulator.c @@ -302,8 +302,9 @@ static int act8945a_pmic_probe(struct platform_device *pdev) num_regulators = ARRAY_SIZE(act8945a_regulators); } + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + config.dev = &pdev->dev; - config.dev->of_node = pdev->dev.parent->of_node; config.driver_data = act8945a; for (i = 0; i < num_regulators; i++) { rdev = devm_regulator_register(&pdev->dev, ®ulators[i], -- 2.52.0