From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F004B3B27DB; Tue, 7 Apr 2026 12:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566133; cv=none; b=qv1f1sIn0skeulsmSWPjqkQQNd0sdcwWFws0zA2CeXTUswi+uU8/Q3+wJ7Pv/tb+2NjTMn05+PqCupbxq3l/oHxKPbwlZq9rFgOhny3ZXrj47p2z6AJxKcIeWIuO3rnErWV48O+IcqlUiCYPTSWksD/LCCErzQz2rW2nIHOIHzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566133; c=relaxed/simple; bh=9gM2k/aOqDg3x+DNA75R0DRTcMQqkKPvr6drbsDSsPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GOxQIfiVpibBzmMZKmcexCanpFwafMcVNrLF/Rbd0fdCfpvnZ3TeuDo8ajacGTGF+5x8K7UNWNiOgWr67bWdEj1pCUikVbX9M6545lQTuuadEMvLsEL7XIAylxJWC6vm5fy3NfA7m21fbgAH2OaXQ8pSE0h8v4VqA0C4vnBcuo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TRd7IXJA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TRd7IXJA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5AB2C2BCB0; Tue, 7 Apr 2026 12:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775566132; bh=9gM2k/aOqDg3x+DNA75R0DRTcMQqkKPvr6drbsDSsPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TRd7IXJAgQxuuJ6z+aeFojkcIKQJIFuqhklGXiUWe3VmhuPQOg9Nlb6C/tB2HtIYr sKsna6voOwv+9GFFFQlPX9IuAK/NA3OZNesWI5dssIdX9M65IukfQHaGCzYWrMeeXN PGKaIGumfr/flgQuzuiiumcJ9ylJjFPPTs4CGoHcr5/cSqOh1UAejdz2xH7Ss+ykhv Dsfvm1iDR8zNxJkl16sPFNLgZcwg6d/uI1U0T95oP4Id+MaXCLweXOCW29wMvTO53t cFsN71CxMrGsLwhpiuDo77jW3hvzvhoa4zbOEKyi9C4MLzyuE1cxG49a1bfQAIQC15 2e3zm6qiv3o5g== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA5rO-0000000BHeT-28Vf; Tue, 07 Apr 2026 14:48:50 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Marek Vasut , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Marek Vasut Subject: [PATCH 2/2] regulator: bd9571mwv: fix OF node reference imbalance Date: Tue, 7 Apr 2026 14:48:36 +0200 Message-ID: <20260407124836.2689436-3-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260407124836.2689436-1-johan@kernel.org> References: <20260407124836.2689436-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: e85c5a153fe2 ("regulator: Add ROHM BD9571MWV-M PMIC regulator driver") Cc: stable@vger.kernel.org # 4.12 Cc: Marek Vasut Signed-off-by: Johan Hovold --- drivers/regulator/bd9571mwv-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c index 209beabb5c37..f4de24a281b1 100644 --- a/drivers/regulator/bd9571mwv-regulator.c +++ b/drivers/regulator/bd9571mwv-regulator.c @@ -287,8 +287,9 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev) platform_set_drvdata(pdev, bdreg); + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + config.dev = &pdev->dev; - config.dev->of_node = pdev->dev.parent->of_node; config.driver_data = bdreg; config.regmap = bdreg->regmap; -- 2.52.0