public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6.18.y] ASoC: qcom: sc7280: make use of common helpers
@ 2026-04-07  8:32 Xilin Wu
  2026-04-08  1:02 ` Sasha Levin
  0 siblings, 1 reply; 2+ messages in thread
From: Xilin Wu @ 2026-04-07  8:32 UTC (permalink / raw)
  To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai
  Cc: Srinivas Kandagatla, linux-sound, linux-arm-msm, linux-kernel,
	stable, Steev Klimaszewski, Xilin Wu

From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

commit 8fdb030fe283c84fd8d378c97ad0f32d6cdec6ce upstream.

sc7280 machine driver can make use of common sdw functions to do most of
the soundwire related operations. Remove such redundant code from sc7280
driver.

[This is a partial backport containing only the sound/soc/qcom/sdw.c
changes which add LPASS CDC DMA DAI IDs to qcom_snd_is_sdw_dai().
The sc7280.c refactoring changes are omitted as they depend on
intermediate patches not present in 6.18.y. The sdw.c change fixes a
NULL pointer dereference for lpass-cpu based SoundWire links.]

Fixes: bcba17279327 ("ASoC: qcom: sdw: fix memory leak for sdw_stream_runtime")
Cc: stable@vger.kernel.org
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Tested-by: Steev Klimaszewski <threeway@gmail.com> # Thinkpad X13s
Link: https://patch.msgid.link/20251022143349.1081513-5-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Xilin Wu <sophon@radxa.com>
---
 sound/soc/qcom/sdw.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c
index 7b2cae92c812..5f880c74c8dc 100644
--- a/sound/soc/qcom/sdw.c
+++ b/sound/soc/qcom/sdw.c
@@ -2,6 +2,7 @@
 // Copyright (c) 2018-2023, Linaro Limited.
 // Copyright (c) 2018, The Linux Foundation. All rights reserved.
 
+#include <dt-bindings/sound/qcom,lpass.h>
 #include <dt-bindings/sound/qcom,q6afe.h>
 #include <linux/module.h>
 #include <sound/soc.h>
@@ -35,6 +36,16 @@ static bool qcom_snd_is_sdw_dai(int id)
 		break;
 	}
 
+	/* DSP Bypass usecase, cpu dai index overlaps with DSP dai ids,
+	 * DO NOT MERGE into top switch case */
+	switch (id) {
+	case LPASS_CDC_DMA_TX3:
+	case LPASS_CDC_DMA_RX0:
+		return true;
+	default:
+		break;
+	}
+
 	return false;
 }
 

---
base-commit: dd26ea937ef593a9c47aa4c85296e6b57a5344a1
change-id: 20260407-qcom-sdw-6-18-2dabe461e17f

Best regards,
--  
Xilin Wu <sophon@radxa.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 6.18.y] ASoC: qcom: sc7280: make use of common helpers
  2026-04-07  8:32 [PATCH 6.18.y] ASoC: qcom: sc7280: make use of common helpers Xilin Wu
@ 2026-04-08  1:02 ` Sasha Levin
  0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2026-04-08  1:02 UTC (permalink / raw)
  To: Xilin Wu; +Cc: stable, Srinivas Kandagatla

On Tue, Apr 07, 2026 at 04:32:05PM +0800, Xilin Wu wrote:
> [This is a partial backport containing only the sound/soc/qcom/sdw.c
> changes which add LPASS CDC DMA DAI IDs to qcom_snd_is_sdw_dai().

Queued for 6.18, thanks.

-- Sasha

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-08  1:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-07  8:32 [PATCH 6.18.y] ASoC: qcom: sc7280: make use of common helpers Xilin Wu
2026-04-08  1:02 ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox