From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 679923BC66C for ; Wed, 8 Apr 2026 12:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652469; cv=none; b=WNz5Ma69V2Unfrp2DsYSsN20eA7rQkttToUxFbZbUkqYKb2WfRcry66adW3BFAq/FAAEbvnbt+LruUa3syee11ibOXLVWNg3FhQNY+LinEF+cOfaD+ADwdHGIpxxUqMlnKmJFuOI7BEPsqDaLWN2lgWGoHbEptyIeg9L2ZNaj1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652469; c=relaxed/simple; bh=hXL9PSy2T9OidFXlN7I43y7vcFLJto4rSFdeRqMTNq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nVAGXL6OHfKR8RWHr/FDfvbNPOZC0D1vkmo1ASlze1NPheiiUW8luiuX1drkGgdzr92ilekX5mCCC57hkNgK+n03GuRqqxSaQUXGkkkUuXKJPiXc1diBvnJ+lkVKcIIksUdFFd23z75sf7g9Xxrhg7ds6k+90CoVEYY9c3TRxsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bf0w2cZ7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bf0w2cZ7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5492C19421; Wed, 8 Apr 2026 12:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775652469; bh=hXL9PSy2T9OidFXlN7I43y7vcFLJto4rSFdeRqMTNq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bf0w2cZ7hIDIzZp88y5oDUOv3cpl3tcFKWa6mvmMxhd/+E7W3lw+imfqxBW+8mFAr zejZcKvoSUYo8aKaMHr6SXNhTzKPiJLf9zZf5AvcvLfgc4rkg3lWlFXy2iwbaEgPux oVNf1iQ1hsCWnoJaQeEmxSVs3yam8I8y+S/n1K570+jqeKKu2iVmbOQGSHvb3Oa9zT e/pqJIiDW076Uq1S7fwC8hwkbXpTSSqFWaMtjj/AE7ddvEWyjD16yWmIWP0mrTTg+1 myKyXTYLA/TC2c0VScwVmqwZOzJ6mPcAT08ryFilL+uvYUNx8Ibqt3Qd95LXpMrIyB RDbCQ+hjSI4Rw== From: Sasha Levin To: stable@vger.kernel.org Cc: Liao Chang , Viresh Kumar , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.1.y 1/2] cpufreq: governor: Free dbs_data directly when gov->init() fails Date: Wed, 8 Apr 2026 08:47:46 -0400 Message-ID: <20260408124747.1019894-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026040816-myth-cleft-0c71@gregkh> References: <2026040816-myth-cleft-0c71@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Liao Chang [ Upstream commit 916f13884042f615cfbfc0b42cc68dadee826f2a ] Due to the kobject embedded in the dbs_data doest not has a release() method yet, it needs to use kfree() to free dbs_data directly when governor fails to allocate the tunner field of dbs_data. Signed-off-by: Liao Chang Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki Stable-dep-of: 6dcf9d0064ce ("cpufreq: governor: fix double free in cpufreq_dbs_governor_init() error path") Signed-off-by: Sasha Levin --- drivers/cpufreq/cpufreq_governor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index c8bca3e77bcea..1a7fcaf39cc9b 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -440,7 +440,7 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) ret = gov->init(dbs_data); if (ret) - goto free_policy_dbs_info; + goto free_dbs_data; /* * The sampling interval should not be less than the transition latency @@ -475,6 +475,8 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) if (!have_governor_per_policy()) gov->gdbs_data = NULL; gov->exit(dbs_data); + +free_dbs_data: kfree(dbs_data); free_policy_dbs_info: -- 2.53.0