From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F8243C1401 for ; Wed, 8 Apr 2026 12:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652470; cv=none; b=asAUg0YPQPPhQt0oVuKSUPyBFuRJh+sI1bA7OefvBU8TWHR/Fp6/PO6tonmGJnlmQZf1gmsuYp5p4QGql9qiTdKd5aTFDWSvZHc7oABHJfozwouJolmeLNXmJEoplwZl12TmuOf1kpKTw7yavX5kCbElEXOgYnC6G1ksBt3HR1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652470; c=relaxed/simple; bh=4c5Jrjdl9OiU/8Hwg1dJn60QlsK9xz3c8wlwsRTLhqw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VGasETKV9q08KfQdnVC4hfLPp8Zeg4PtYlBoJ20lp5jxCWT2byKDkaqzPRVd6a9c+NWEA+PbNfl6aHDo/y/v2d6dYJLRi8lmXyTcn2UVaaDDonSJUKv8w83F5vRqdCqHdNeL9eFfXNlWqfNz5zqMdWgHB/TnVZav0+hvf3vnvIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K0VUgkjH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K0VUgkjH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B3D6C19421; Wed, 8 Apr 2026 12:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775652470; bh=4c5Jrjdl9OiU/8Hwg1dJn60QlsK9xz3c8wlwsRTLhqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K0VUgkjH+CA8PB5IHbEo+RmxoAwWXJD15CPsvPaE9C6EgTVFUHRipuQ8o5ZNPZgsd FL6+QLW9HDZ546SWEGHIJu7/aWkcNLnS6sx+kfRFHF6CWaVuCmN5w2GL2ALlbiA8qA tih/fFaqzz7Suoo2N9Z/AlzndsAF8d3xltj/HXIt8N+iNnl4xS1RF/NbTYEPunPOV+ IKqmU8UilVDVvm2JZPwRG4bFn5zz44RWVQf+2wQtKNrzbCx8aYfTH3Vb/rRzZiZ/Gg xb9mvujPU4GhFmRNi2ldoXM9PBJjImwijyclC+KdyHhTobLifmpNgZUvxPLwsmB1S7 y5DggSRi0b23Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Guangshuo Li , Zhongqiu Han , Viresh Kumar , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.1.y 2/2] cpufreq: governor: fix double free in cpufreq_dbs_governor_init() error path Date: Wed, 8 Apr 2026 08:47:47 -0400 Message-ID: <20260408124747.1019894-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408124747.1019894-1-sashal@kernel.org> References: <2026040816-myth-cleft-0c71@gregkh> <20260408124747.1019894-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Guangshuo Li [ Upstream commit 6dcf9d0064ce2f3e3dfe5755f98b93abe6a98e1e ] When kobject_init_and_add() fails, cpufreq_dbs_governor_init() calls kobject_put(&dbs_data->attr_set.kobj). The kobject release callback cpufreq_dbs_data_release() calls gov->exit(dbs_data) and kfree(dbs_data), but the current error path then calls gov->exit(dbs_data) and kfree(dbs_data) again, causing a double free. Keep the direct kfree(dbs_data) for the gov->init() failure path, but after kobject_init_and_add() has been called, let kobject_put() handle the cleanup through cpufreq_dbs_data_release(). Fixes: 4ebe36c94aed ("cpufreq: Fix kobject memleak") Signed-off-by: Guangshuo Li Reviewed-by: Zhongqiu Han Acked-by: Viresh Kumar Cc: All applicable Link: https://patch.msgid.link/20260401024535.1395801-1-lgs201920130244@gmail.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/cpufreq_governor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 1a7fcaf39cc9b..3ad51a9867812 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -468,13 +468,13 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) /* Failure, so roll back. */ pr_err("initialization failed (dbs_data kobject init error %d)\n", ret); - kobject_put(&dbs_data->attr_set.kobj); - policy->governor_data = NULL; if (!have_governor_per_policy()) gov->gdbs_data = NULL; - gov->exit(dbs_data); + + kobject_put(&dbs_data->attr_set.kobj); + goto free_policy_dbs_info; free_dbs_data: kfree(dbs_data); -- 2.53.0