From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8B3C3C9EC7 for ; Wed, 8 Apr 2026 13:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775653326; cv=none; b=RRHCfbs0QtMfMQP1STazUgoF+WbaIjB5hJ1arrd0egRF28XaJDgChDuF4wfL9K/0msJsxOmiHgLTmErUX/q+mmAmv0Lca7lz95bREX3eGpA/dlhlEjj+n7YzET9ElwKSY+avOSxawNU0ZMxH+D8UrNqXyKBXNxS6Tgb3IY9XksM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775653326; c=relaxed/simple; bh=a3x8N+nRg7fJIbKxWC+YdOBXoj6GQZwF3OnwbP2BUh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MUSD8mWEJ1YFji7ZqLlUkdu7+1q4GVlwSIYTSMOPYyyCdy07ZmOrtwirCZpPLne3fJedo/AlOCsiL/ukQKV7Ilbxg5PqKZmrzD7yN+48lLEq1hkXXbbs5PER5KxEohLy0aWyQyb4Y/z4wqbxb3ba/KojuftFLu7rD+d3NPpns8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fLfk6z1G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fLfk6z1G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09722C2BCAF; Wed, 8 Apr 2026 13:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775653325; bh=a3x8N+nRg7fJIbKxWC+YdOBXoj6GQZwF3OnwbP2BUh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fLfk6z1GMV7YL7TmpuOZcsYiaovNmaLpBgtJ2HigTJgbfnz31nflBxDsumlaHNVDR Fh09JXaB8cHq6X1tAJ/uENpIGn4kChJchKJ66zywYJR8id0z8JVXheeg+9+UNZdbiH pRnNIV50HoZufzulC2zzGpssZ01osTuhfC8Q3x1UO3qfC2dZCsTTmG2yESlDxH89zz bMl3luyDcQV9FfDENyHhRGtm071LcWNXTfr3GUwh4r9EXd14lEYyhJFiSDQrQ+Nxk6 R5c6COgCISFRYk9iJEZrx9V1MUiQmLIYbFpGa5gMuQER4ZD572HUK97fReW8CYMbnA g8SKA2cKrDDHQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Guangshuo Li , Zhongqiu Han , Viresh Kumar , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.10.y 2/2] cpufreq: governor: fix double free in cpufreq_dbs_governor_init() error path Date: Wed, 8 Apr 2026 09:02:02 -0400 Message-ID: <20260408130202.1050557-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408130202.1050557-1-sashal@kernel.org> References: <2026040817-dotted-shredder-9229@gregkh> <20260408130202.1050557-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Guangshuo Li [ Upstream commit 6dcf9d0064ce2f3e3dfe5755f98b93abe6a98e1e ] When kobject_init_and_add() fails, cpufreq_dbs_governor_init() calls kobject_put(&dbs_data->attr_set.kobj). The kobject release callback cpufreq_dbs_data_release() calls gov->exit(dbs_data) and kfree(dbs_data), but the current error path then calls gov->exit(dbs_data) and kfree(dbs_data) again, causing a double free. Keep the direct kfree(dbs_data) for the gov->init() failure path, but after kobject_init_and_add() has been called, let kobject_put() handle the cleanup through cpufreq_dbs_data_release(). Fixes: 4ebe36c94aed ("cpufreq: Fix kobject memleak") Signed-off-by: Guangshuo Li Reviewed-by: Zhongqiu Han Acked-by: Viresh Kumar Cc: All applicable Link: https://patch.msgid.link/20260401024535.1395801-1-lgs201920130244@gmail.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/cpufreq_governor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 960dcd6384b02..244a43a4a0976 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -457,13 +457,13 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) /* Failure, so roll back. */ pr_err("initialization failed (dbs_data kobject init error %d)\n", ret); - kobject_put(&dbs_data->attr_set.kobj); - policy->governor_data = NULL; if (!have_governor_per_policy()) gov->gdbs_data = NULL; - gov->exit(dbs_data); + + kobject_put(&dbs_data->attr_set.kobj); + goto free_policy_dbs_info; free_dbs_data: kfree(dbs_data); -- 2.53.0