From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E37A3CEB85 for ; Wed, 8 Apr 2026 14:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775658107; cv=none; b=JyWWFWwYYqY8R0VCyRMqOXMmlfHMgAEf0Sz5cYd6IOkLo41tdGNKe02rjnNcDAAee5qRvSFyyhbAd9Vvu/L0O+P3KtMOjL2c9pui5LkEILJdaC922xOfLJIgcH9RYd2s+NtXfRIaHVRQBy+7sg5Er7nCuRbpH5XFhrU4JBWVbkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775658107; c=relaxed/simple; bh=YWw5Y7n7Ugicw2fILsW6jxyZ2TWfGe7ArrBz/JPwNFc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YxV9UWtrV72GusGempzBM221ARunT4WfJSNA7QAL0ULrfRCKZzuwczgi0zbFavvWZ/55vq3El8r8ve0ZzWAkW2kqrk+Rd68qwVYgQrOUqyXrCiu2SU94H95B6rJ7PiB/TotSsxn0roROksQ51j7xCtKdD1qPq7QlnSg6xU97o8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lSU77/8F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lSU77/8F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BB4AC19421; Wed, 8 Apr 2026 14:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775658107; bh=YWw5Y7n7Ugicw2fILsW6jxyZ2TWfGe7ArrBz/JPwNFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lSU77/8FIDXaVtElITHWBIXN4Nj65Ip+Aq0wvc5I6ucIl9AEO592NtBVGK93qhrWi oYGFClHIgssntjHDXnZWY2sR5UlwK3I/c8mkuZXqo8uLUY56QTwaZnEZzOxY+NYC2u MuarQ2Glg0bQFJ8jDNlzGE8qKsC4ga5KUpCnL/FNsx28+NXQugUpDQ1H3Grht0a54a oSQ8gvRdEkR92TyOGk1M66Ud7KmPxWKj0CHN3+J0f/r4o8XuuEeao42YiLYBv3p/id rmB34DczDp6cMcMIYp8uXDt4v0WylNH18z4pFaaUE1Sqt8kQBcwYqmJ1Pd3v5BhEGF 0BiWk8KPjfIYQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Xingjing Deng , Xingjing Deng , Dmitry Baryshkov , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 6.12.y] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe Date: Wed, 8 Apr 2026 10:21:44 -0400 Message-ID: <20260408142144.1124899-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026040853-keg-enchanted-fd3d@gregkh> References: <2026040853-keg-enchanted-fd3d@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Xingjing Deng [ Upstream commit 6a502776f4a4f80fb839b22f12aeaf0267fca344 ] In the SDSP probe path, qcom_scm_assign_mem() is used to assign the reserved memory to the configured VMIDs, but its return value was not checked. Fail the probe if the SCM call fails to avoid continuing with an unexpected/incorrect memory permission configuration. This issue was found by an in-house analysis workflow that extracts AST-based information and runs static checks, with LLM assistance for triage, and was confirmed by manual code review. No hardware testing was performed. Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access to the DSP") Cc: stable@vger.kernel.org # 6.11-rc1 Signed-off-by: Xingjing Deng Reviewed-by: Dmitry Baryshkov Link: https://patch.msgid.link/20260131065539.2124047-1-xjdeng@buaa.edu.cn Signed-off-by: Greg Kroah-Hartman [ adapted qcom_scm_assign_mem() error check to use fdev_error label and rmem-based memory API ] Signed-off-by: Sasha Levin --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index d6c55c338b062..d3d4d50fb0e54 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2345,8 +2345,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) src_perms = BIT(QCOM_SCM_VMID_HLOS); - qcom_scm_assign_mem(rmem->base, rmem->size, &src_perms, + err = qcom_scm_assign_mem(rmem->base, rmem->size, &src_perms, data->vmperms, data->vmcount); + if (err) + goto fdev_error; } -- 2.53.0