From: Al Viro <viro@zeniv.linux.org.uk>
To: Arpith Kalaginanavoor <arpithk@nvidia.com>
Cc: brauner@kernel.org, stable@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs/qnx6: fix pointer arithmetic in directory iteration
Date: Wed, 8 Apr 2026 18:35:27 +0100 [thread overview]
Message-ID: <20260408173527.GH3836593@ZenIV> (raw)
In-Reply-To: <20260310102233.391113-1-arpithk@nvidia.com>
On Tue, Mar 10, 2026 at 03:22:33AM -0700, Arpith Kalaginanavoor wrote:
> diff --git a/fs/qnx6/dir.c b/fs/qnx6/dir.c
> index ae0c9846833d..ba5cae49ad1d 100644
> --- a/fs/qnx6/dir.c
> +++ b/fs/qnx6/dir.c
> @@ -139,8 +139,8 @@ static int qnx6_readdir(struct file *file, struct dir_context *ctx)
> ctx->pos = (n + 1) << PAGE_SHIFT;
> return PTR_ERR(kaddr);
> }
> - de = (struct qnx6_dir_entry *)(kaddr + offset);
> - limit = kaddr + last_entry(inode, n);
> + de = (struct qnx6_dir_entry *)(kaddr + (offset * QNX6_DIR_ENTRY_SIZE));
> + limit = kaddr + (last_entry(inode, n) * QNX6_DIR_ENTRY_SIZE);
Why not simply
de = (struct qnx6_dir_entry *)kaddr + offset;
limit = (struct qnx6_dir_entry *)kaddr + last_entry(inode, n);
instead of open-coding the multiplication?
prev parent reply other threads:[~2026-04-08 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 10:22 [PATCH] fs/qnx6: fix pointer arithmetic in directory iteration Arpith Kalaginanavoor
2026-04-08 17:35 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408173527.GH3836593@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=arpithk@nvidia.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox