Re: [PATCH 6.6 111/160] vfio: Create vfio_fs_type with inode per device

Sasha Levin
2026-04-08T22:32:50Z

On Wed, Apr 08, 2026 at 09:44:13PM +0200, Greg Kroah-Hartman wrote:
>On Wed, Apr 08, 2026 at 08:03:18PM +0200, Greg Kroah-Hartman wrote:
>> 6.6-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Alex Williamson <alex.williamson@redhat.com>
>>
>> commit b7c5e64fecfa88764791679cca4786ac65de739e upstream.
>>
>> By linking all the device fds we provide to userspace to an
>> address space through a new pseudo fs, we can use tools like
>> unmap_mapping_range() to zap all vmas associated with a device.
>>
>> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
>> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
>> Link: https://lore.kernel.org/r/20240530045236.1005864-2-alex.williamson@redhat.com
>> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
>> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
>> Signed-off-by: Tugrul Kukul <tugrul.kukul@est.tech>
>> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
>> Tested-by: Pavel Machek (CIP) <pavel@denx.de>
>> Tested-by: Ron Economos <re@w6rz.net>
>> Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>
>> Tested-by: Mark Brown <broonie@kernel.org>
>> Tested-by: Conor Dooley <conor.dooley@microchip.com>
>> Tested-by: Jon Hunter <jonathanh@nvidia.com>
>> Tested-by: Shuah Khan <skhan@linuxfoundation.org>
>> Tested-by: Peter Schneider <pschneider1968@googlemail.com>
>> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
>> Acked-by: Alex Williamson <alex@shazbot.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Sasha, something went odd with your scripts to pull all of these names
>in as "tested-by", right? The original commit did not say that :(

Argh... I switched to using b4 to pick up backports that folks send on the
mailing list. Looks like it picks up trailers from unrelated messages...

$ b4 am 20260402161311.63484-2-tugrul.kukul@est.tech
Looking up https://lore.kernel.org/all/20260402161311.63484-2-tugrul.kukul@est.tech/
Grabbing thread from lore.kernel.org/all/20260402161311.63484-2-tugrul.kukul@est.tech/t.mbox.gz
Breaking thread to remove parents of 20260402161311.63484-1-tugrul.kukul@est.tech
Analyzing 7 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 423 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH 1/4] vfio: Create vfio_fs_type with inode per device
+ Tested-by: Jon Hunter <jonathanh@nvidia.com> (✓ DKIM/nvidia.com)
+ Tested-by: Pavel Machek (CIP) <pavel@denx.de>
+ Tested-by: Shuah Khan <skhan@linuxfoundation.org> (✗ DKIM/linuxfoundation.org)
+ Tested-by: Peter Schneider <pschneider1968@googlemail.com> (✗ DKIM/googlemail.com)
+ Tested-by: Ron Economos <re@w6rz.net> (✗ DKIM/w6rz.net)
+ Tested-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
+ Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> (✗ DKIM/gmail.com)
+ Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> (✗ DKIM/linuxtx.org)
+ Tested-by: Mark Brown <broonie@kernel.org> (✓ DKIM/kernel.org)
+ Reviewed-by: Alex Williamson <alex.williamson@redhat.com> (✓ DKIM/redhat.com)
+ Acked-by: Alex Williamson <alex@shazbot.org> (✓ DKIM/shazbot.org)
✓ [PATCH 2/4] vfio/pci: Use unmap_mapping_range()
+ Acked-by: Alex Williamson <alex@shazbot.org> (✓ DKIM/shazbot.org)
✓ [PATCH 3/4] vfio/pci: Insert full vma on mmap'd MMIO fault
+ Tested-by: Jon Hunter <jonathanh@nvidia.com> (✓ DKIM/nvidia.com)
+ Tested-by: Pavel Machek (CIP) <pavel@denx.de>
+ Tested-by: Shuah Khan <skhan@linuxfoundation.org> (✗ DKIM/linuxfoundation.org)
+ Tested-by: Peter Schneider <pschneider1968@googlemail.com> (✗ DKIM/googlemail.com)
+ Tested-by: Ron Economos <re@w6rz.net> (✗ DKIM/w6rz.net)
+ Tested-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
+ Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> (✗ DKIM/gmail.com)
+ Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> (✗ DKIM/linuxtx.org)
+ Tested-by: Mark Brown <broonie@kernel.org> (✓ DKIM/kernel.org)
+ Reviewed-by: Alex Williamson <alex.williamson@redhat.com> (✓ DKIM/redhat.com)
+ Acked-by: Alex Williamson <alex@shazbot.org> (✓ DKIM/shazbot.org)
✓ [PATCH 4/4] fork: defer linking file vma until vma is fully initialized
+ Acked-by: Alex Williamson <alex@shazbot.org> (✓ DKIM/shazbot.org)
---
✓ Signed: DKIM/est.tech
---
Total patches: 4

Let me investigate if this is a bug or whether I should be passing something to
b4 to make it not do that.

--
Thanks,
Sasha