From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C49241A285; Wed, 8 Apr 2026 18:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775673792; cv=none; b=g1Mxjg3vASdWCRhN9LkJr0Z19lB66jRDiFZDjius5gb9vn5MKybRFTuQET/FiOYv2xjch73PAL7HrT5Uqt7wdcZQ4Qh/TGmzYrnclz6v3FGeaaPsCR2LC1gIZ5BgFehPKoNK5IOvi7ObqUgGuP/VBuEWwmjvSU5eZPie1Wad3nI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775673792; c=relaxed/simple; bh=yI/DxdUgbzYFkYb4CpeHT8XcU1yS1moH6KbWy/4nHt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NkwV+COiBHu+CuPmhqRST9mh4DIq+twAIi1j3px2o2HIXmcARqvoAd+CwOoNOCXKAP0ujtFzyiWH/e3clMdOX0tBRUOFch/0kjclc74h6gR2BF2EuMnyEmYHCKdE0G5NO5XJlqIRyfwrAbFAQDDAF72aNYqG0oOu7FgWr4BqR18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bflwfBZa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bflwfBZa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A3B0C19421; Wed, 8 Apr 2026 18:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775673792; bh=yI/DxdUgbzYFkYb4CpeHT8XcU1yS1moH6KbWy/4nHt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bflwfBZalSCpzWKLGe/Yo6dl2odDmoLb7nSDzhwUEKTqrrBFlk8uuBtUlP64Sv/lT otnUkD8oNf+S982bNYYkJuSbnHFjz8qSo82odEBEQUF1uSfOfxl+su+wDeQmjalXaM Rwg+hAGlOjlR1emHeQgnnFBPbrcEfyvufIyI0jb0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shay Drory , Mark Bloch , Tariq Toukan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 091/242] net/mlx5: lag: Check for LAG device before creating debugfs Date: Wed, 8 Apr 2026 20:02:11 +0200 Message-ID: <20260408175930.490880123@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175927.064985309@linuxfoundation.org> References: <20260408175927.064985309@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shay Drory [ Upstream commit bf16bca6653679d8a514d6c1c5a2c67065033f14 ] __mlx5_lag_dev_add_mdev() may return 0 (success) even when an error occurs that is handled gracefully. Consequently, the initialization flow proceeds to call mlx5_ldev_add_debugfs() even when there is no valid LAG context. mlx5_ldev_add_debugfs() blindly created the debugfs directory and attributes. This exposed interfaces (like the members file) that rely on a valid ldev pointer, leading to potential NULL pointer dereferences if accessed when ldev is NULL. Add a check to verify that mlx5_lag_dev(dev) returns a valid pointer before attempting to create the debugfs entries. Fixes: 7f46a0b7327a ("net/mlx5: Lag, add debugfs to query hardware lag state") Signed-off-by: Shay Drory Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan Link: https://patch.msgid.link/20260330194015.53585-2-tariqt@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c index f4b777d4e1086..41ddca52e9547 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c @@ -163,8 +163,11 @@ DEFINE_SHOW_ATTRIBUTE(members); void mlx5_ldev_add_debugfs(struct mlx5_core_dev *dev) { + struct mlx5_lag *ldev = mlx5_lag_dev(dev); struct dentry *dbg; + if (!ldev) + return; dbg = debugfs_create_dir("lag", mlx5_debugfs_get_dev_root(dev)); dev->priv.dbg.lag_debugfs = dbg; -- 2.53.0