From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB4D3D47A5; Wed, 8 Apr 2026 18:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775671791; cv=none; b=LBNt+4B1Nu679LETWEZnTHWVo3tKRpTmYK2MstlEkyloLfoRDIy1YNoVZOoV04mO7pHvqMWjdN5HfYHSrKLNjipewRiAnECHUtBdpwW2FKlXM7P4ouR0txfpjdqe1hG+CKr2gB61JXh07O4FCnYR9Y4CQZlcW2M0Rg4fHrBb3iY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775671791; c=relaxed/simple; bh=qHt+/D2VW5aZ5b1iUx7TcyCXpZbTYurkCnQv/n3B8Ok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WsGSiGRyMUM9lpaMXVKXN38VLZivdKD0eDlcAcrhSzwChL+Um2ivtVdnOpDFT7tMnsc4mUO3WGG9oEGoQjeOlCpIoShhbEyLhP8e6VUB6LtWDFw6+VL/1dGVsJ/UMmlqT4FE0GlN+aLsvXOLATegwUXTT0wNLGRx8t6Va8cGJ98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wqAJor0A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wqAJor0A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46D56C19421; Wed, 8 Apr 2026 18:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775671791; bh=qHt+/D2VW5aZ5b1iUx7TcyCXpZbTYurkCnQv/n3B8Ok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wqAJor0AUv6RaoeXUD7/j4wwGZ0KeA/SRP4z47cJ99du7DV6WRXA3phKEHp7WAKoI pXhmby2xkx7E1O16VKEVg/sIPkA6yMhcnSOajZ3rOCd7B8pcVWsqJ9RRA/dC1EszOi XFWZ6kbaEvXFJ0otyY5Vd3ECZ5B/osdVrxT9zcUU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ivan Barrera , Tatyana Nikolova , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.1 069/312] RDMA/irdma: Clean up unnecessary dereference of event->cm_node Date: Wed, 8 Apr 2026 19:59:46 +0200 Message-ID: <20260408175936.317272503@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175933.715315542@linuxfoundation.org> References: <20260408175933.715315542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Barrera [ Upstream commit b415399c9a024d574b65479636f0d4eb625b9abd ] The cm_node is available and the usage of cm_node and event->cm_node seems arbitrary. Clean up unnecessary dereference of event->cm_node. Fixes: 146b9756f14c ("RDMA/irdma: Add connection manager") Signed-off-by: Ivan Barrera Signed-off-by: Tatyana Nikolova Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/irdma/cm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c index 691b9ed7f759d..b8f945576eb53 100644 --- a/drivers/infiniband/hw/irdma/cm.c +++ b/drivers/infiniband/hw/irdma/cm.c @@ -4181,21 +4181,21 @@ static void irdma_cm_event_handler(struct work_struct *work) irdma_cm_event_reset(event); break; case IRDMA_CM_EVENT_CONNECTED: - if (!event->cm_node->cm_id || - event->cm_node->state != IRDMA_CM_STATE_OFFLOADED) + if (!cm_node->cm_id || + cm_node->state != IRDMA_CM_STATE_OFFLOADED) break; irdma_cm_event_connected(event); break; case IRDMA_CM_EVENT_MPA_REJECT: - if (!event->cm_node->cm_id || + if (!cm_node->cm_id || cm_node->state == IRDMA_CM_STATE_OFFLOADED) break; irdma_send_cm_event(cm_node, cm_node->cm_id, IW_CM_EVENT_CONNECT_REPLY, -ECONNREFUSED); break; case IRDMA_CM_EVENT_ABORTED: - if (!event->cm_node->cm_id || - event->cm_node->state == IRDMA_CM_STATE_OFFLOADED) + if (!cm_node->cm_id || + cm_node->state == IRDMA_CM_STATE_OFFLOADED) break; irdma_event_connect_error(event); break; @@ -4205,7 +4205,7 @@ static void irdma_cm_event_handler(struct work_struct *work) break; } - irdma_rem_ref_cm_node(event->cm_node); + irdma_rem_ref_cm_node(cm_node); kfree(event); } -- 2.53.0