From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0872E3AEF45; Wed, 8 Apr 2026 18:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672062; cv=none; b=ZqKzK5oTJ0RB66ZaHXM2YedLqA5qtvid8oRL5Z1rU9ND0cnp9noTvyct0p0jBfNnQ268weP6EBXzAMchrrBb0O2h1g1h4xp0E5F/xjCBi2Ps5xyyV4FzJf+p3px1SQzshA7ftww5p120prpWgNSP4j1a8qszT9cJE5wKyi1hrX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672062; c=relaxed/simple; bh=NkXerALGKljk1r/n+e5ob4R5XR28mI1iiut+ltV5Zug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lvNPreoLJTpUppw5CGdt999u/WtjKzcxbeHIjrvabEWSxzAWaZahlgi8BSJsxxiwUDKP/S8QTVlL1fxqbsWl1FqbV/FeyWb9d/1jsvr4Scohi5mnvBg3sWFiWTI7EtL9T3DkxdJL1uq+h+FFGfpnID7ny880DxzFpksPODUMpWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Bdg45kbF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Bdg45kbF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EFEC19421; Wed, 8 Apr 2026 18:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775672061; bh=NkXerALGKljk1r/n+e5ob4R5XR28mI1iiut+ltV5Zug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bdg45kbFrogCC/geiq1xP92VclZUhQXUMyQe5xEmkI2nsYMR5D77D20zbPWiQtvDP 2OBOYBroC5JxOgNBVNRH7G9946DUlOYc6O3+5KQ1OdwKqcKzEi6g/9anrC78OZQETZ 7eLclGJTmPyYOlOHCvHDk+Q6Km+SsDiAGBm/YnDA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jakub Kicinski , Paolo Abeni , Sasha Levin Subject: [PATCH 6.1 157/312] ipv6: prevent possible UaF in addrconf_permanent_addr() Date: Wed, 8 Apr 2026 20:01:14 +0200 Message-ID: <20260408175939.629228042@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175933.715315542@linuxfoundation.org> References: <20260408175933.715315542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paolo Abeni [ Upstream commit fd63f185979b047fb22a0dfc6bd94d0cab6a6a70 ] The mentioned helper try to warn the user about an exceptional condition, but the message is delivered too late, accessing the ipv6 after its possible deletion. Reorder the statement to avoid the possible UaF; while at it, place the warning outside the idev->lock as it needs no protection. Reported-by: Jakub Kicinski Closes: https://sashiko.dev/#/patchset/8c8bfe2e1a324e501f0e15fef404a77443fd8caf.1774365668.git.pabeni%40redhat.com Fixes: f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional") Signed-off-by: Paolo Abeni Link: https://patch.msgid.link/ef973c3a8cb4f8f1787ed469f3e5391b9fe95aa0.1774601542.git.pabeni@redhat.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/addrconf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index d6a33452dd369..801ecec3c15ba 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -3566,12 +3566,12 @@ static void addrconf_permanent_addr(struct net *net, struct net_device *dev) if ((ifp->flags & IFA_F_PERMANENT) && fixup_permanent_addr(net, idev, ifp) < 0) { write_unlock_bh(&idev->lock); - in6_ifa_hold(ifp); - ipv6_del_addr(ifp); - write_lock_bh(&idev->lock); net_info_ratelimited("%s: Failed to add prefix route for address %pI6c; dropping\n", idev->dev->name, &ifp->addr); + in6_ifa_hold(ifp); + ipv6_del_addr(ifp); + write_lock_bh(&idev->lock); } } -- 2.53.0