From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899431E5724; Wed, 8 Apr 2026 18:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672041; cv=none; b=B+SJIddJr71SXwcjYYem1ayCo0dtJfknIx+kK0QYCoTp6f448laXkjSCgaZX20duAjR4ZDfq/4U8kRssMjzYWBoiALHqCm0p8Jp+KDGyPwKgdztnVVeydkaNCRVxQ1/MBNaO1e/Qav96r1ZhNpDNqUASdYmg+hPzT6hSVmXll4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672041; c=relaxed/simple; bh=GCqqhM/tmRFuEolEKj/5SmNRRNfDHmwiADgFKdmIaB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OUghthLhfwe2f9tjr2DqfGVkZoAftjZ9py4sMDHeHBSgqnNpOuEmeoHhIL6ew2ZuFq2YCc94ZMye4gLkVtbZsA6pwmMgKgLWdDckLTwT7B1HEQXRbD92iiqxMj+539VjyKhp4hkC9fjmjew6/yfYyz+7JBO+UjTlpr9puU4JGHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yER1C+5u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yER1C+5u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 089ABC19421; Wed, 8 Apr 2026 18:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775672041; bh=GCqqhM/tmRFuEolEKj/5SmNRRNfDHmwiADgFKdmIaB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yER1C+5uZkWsVJh/79SAMKzAti9jcGaAiftE1nfdoYTk8f+XZc0XqiY/RKdq+97Yr gQOhKlaA9yAMYGtv4E6uppDpJy7Lda1Ocl4dHmoGb7CGaSCEK6k5ZaIPBC2oSDn/GJ NiiJ/E4AGbieTY1y0FK+JkO1Mc+xT/EHkMnLXGe0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qi Tang , Phil Sutter , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 6.1 167/312] netfilter: nf_conntrack_helper: pass helper to expect cleanup Date: Wed, 8 Apr 2026 20:01:24 +0200 Message-ID: <20260408175940.002063007@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175933.715315542@linuxfoundation.org> References: <20260408175933.715315542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qi Tang [ Upstream commit a242a9ae58aa46ff7dae51ce64150a93957abe65 ] nf_conntrack_helper_unregister() calls nf_ct_expect_iterate_destroy() to remove expectations belonging to the helper being unregistered. However, it passes NULL instead of the helper pointer as the data argument, so expect_iter_me() never matches any expectation and all of them survive the cleanup. After unregister returns, nfnl_cthelper_del() frees the helper object immediately. Subsequent expectation dumps or packet-driven init_conntrack() calls then dereference the freed exp->helper, causing a use-after-free. Pass the actual helper pointer so expectations referencing it are properly destroyed before the helper object is freed. BUG: KASAN: slab-use-after-free in string+0x38f/0x430 Read of size 1 at addr ffff888003b14d20 by task poc/103 Call Trace: string+0x38f/0x430 vsnprintf+0x3cc/0x1170 seq_printf+0x17a/0x240 exp_seq_show+0x2e5/0x560 seq_read_iter+0x419/0x1280 proc_reg_read+0x1ac/0x270 vfs_read+0x179/0x930 ksys_read+0xef/0x1c0 Freed by task 103: The buggy address is located 32 bytes inside of freed 192-byte region [ffff888003b14d00, ffff888003b14dc0) Fixes: ac7b84839003 ("netfilter: expect: add and use nf_ct_expect_iterate helpers") Signed-off-by: Qi Tang Reviewed-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index 5545016c107db..2a15176731fe8 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -422,7 +422,7 @@ void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me) */ synchronize_rcu(); - nf_ct_expect_iterate_destroy(expect_iter_me, NULL); + nf_ct_expect_iterate_destroy(expect_iter_me, me); nf_ct_iterate_destroy(unhelp, me); } EXPORT_SYMBOL_GPL(nf_conntrack_helper_unregister); -- 2.53.0