From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC23347503; Wed, 8 Apr 2026 18:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672082; cv=none; b=CL8Abis/QrhhgOrsvqvbQKaAHHhOqNTa2agw1mY6qABWeJlWuGYmC8vi2ut7Z7whZeyDpp0YXx6Z2JiGeCb/rNbIMBpa7pH8uoqQCIXxvIBkZ2VgaZVvRpGgDgJaFFMrGNBEGVPNIt8cZ3CoVIc7FZQU+GLl32yAS/w/Y6EPhhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672082; c=relaxed/simple; bh=1naO93hu6ROoNKRLY+YVOpqe8e10VcaAEGCTsYiAKR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mYGs/xA1OLXnGBb+PuClmCgRNqtFcmj19qGUS+9jRdZOwuulcUDdL3/4MOqjp9UcxPkyK/1uQCzyEtPnzkJxrrx/uUugvyk2Db4NWU/17U5xAv1KfLMp16y48cXX2p169soOaPQ3prxCWR2XsxS2V+yGhPKyB69H9QCSkPwkIp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xrESPO7E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xrESPO7E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26124C19421; Wed, 8 Apr 2026 18:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775672082; bh=1naO93hu6ROoNKRLY+YVOpqe8e10VcaAEGCTsYiAKR4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xrESPO7EGEkcmMMpauVGMK9JxH3wBskL9cTlChjnzy8BZ0FPTnpYrjXYj5BbYlmnh Khg1Yawf8+DqcE0wUMevjuqXGJr6vKEmh9NBj4jITzwAYd5NBWfmTdcNWCASwNK9iw 5HJRMOQTjvtbbpmEF19RDl905BH4g3Fek9qa1lfU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fedor Pchelkin , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 182/312] net: macb: properly unregister fixed rate clocks Date: Wed, 8 Apr 2026 20:01:39 +0200 Message-ID: <20260408175940.561066875@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175933.715315542@linuxfoundation.org> References: <20260408175933.715315542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fedor Pchelkin [ Upstream commit f0f367a4f459cc8118aadc43c6bba53c60d93f8d ] The additional resources allocated with clk_register_fixed_rate() need to be released with clk_unregister_fixed_rate(), otherwise they are lost. Fixes: 83a77e9ec415 ("net: macb: Added PCI wrapper for Platform Driver.") Signed-off-by: Fedor Pchelkin Link: https://patch.msgid.link/20260330184542.626619-2-pchelkin@ispras.ru Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/cadence/macb_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c index 4dd0cec2e5423..34e249e0e5860 100644 --- a/drivers/net/ethernet/cadence/macb_pci.c +++ b/drivers/net/ethernet/cadence/macb_pci.c @@ -97,10 +97,10 @@ static int macb_probe(struct pci_dev *pdev, const struct pci_device_id *id) return 0; err_plat_dev_register: - clk_unregister(plat_data.hclk); + clk_unregister_fixed_rate(plat_data.hclk); err_hclk_register: - clk_unregister(plat_data.pclk); + clk_unregister_fixed_rate(plat_data.pclk); err_pclk_register: return err; @@ -114,8 +114,8 @@ static void macb_remove(struct pci_dev *pdev) struct clk *hclk = plat_data->hclk; platform_device_unregister(plat_dev); - clk_unregister(pclk); - clk_unregister(hclk); + clk_unregister_fixed_rate(pclk); + clk_unregister_fixed_rate(hclk); } static const struct pci_device_id dev_id_table[] = { -- 2.53.0