From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B303AEF45; Wed, 8 Apr 2026 18:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672085; cv=none; b=rh/4ILrk9X4TBoabAcP4M3YZGFZg80+rCrt+IlAojh6TkewZ8ItD0IPfaia+rqM30XhQTugtYxDpGkPQ2V74fh8XQGsDl/bPkaY8fPBDOlU4zy8uXe64Dy0Kcdv4+8kiCACWFNYqYU7QnQKrHY0cn9KPLmI+NpztwhOs/kJpspk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775672085; c=relaxed/simple; bh=1BrArdDNwDbMhoR/IHM/A/VZIPVO2TWJpjrmb3JRey0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AOnBuv3Qkzn1ZMfayZiB5v+99GaGYYpnomahR3KCUzIXO25uzULQ8f7arcRBGo/geDMdItWIbVzSDq/LCH69UGPfL+/oeazhVzc0BBemeBy4a4OEvV52eUYHTsf5g1WUobVpWCqL3pQEuJcP3j65/2DZlgGH4JnjMMnG6yEWWyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Dkegdr5d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Dkegdr5d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1048C19421; Wed, 8 Apr 2026 18:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775672085; bh=1BrArdDNwDbMhoR/IHM/A/VZIPVO2TWJpjrmb3JRey0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dkegdr5dpdoT63FOa02+mY3jJeMeCiASp8+AKFmmZPRCtpzvAWEIsZVX3dflIB0Qj 6PxhjjQr6AMbBa/4f+F4xlZiM8QYvX7C5yyFXnHgLrWRR6LxsxAFQOAG4Buvam6uoq CdpUneFfYhaC036haZT32r/vHpnlZ4PuSKsOBb1s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shay Drory , Mark Bloch , Tariq Toukan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 183/312] net/mlx5: lag: Check for LAG device before creating debugfs Date: Wed, 8 Apr 2026 20:01:40 +0200 Message-ID: <20260408175940.598456234@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175933.715315542@linuxfoundation.org> References: <20260408175933.715315542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shay Drory [ Upstream commit bf16bca6653679d8a514d6c1c5a2c67065033f14 ] __mlx5_lag_dev_add_mdev() may return 0 (success) even when an error occurs that is handled gracefully. Consequently, the initialization flow proceeds to call mlx5_ldev_add_debugfs() even when there is no valid LAG context. mlx5_ldev_add_debugfs() blindly created the debugfs directory and attributes. This exposed interfaces (like the members file) that rely on a valid ldev pointer, leading to potential NULL pointer dereferences if accessed when ldev is NULL. Add a check to verify that mlx5_lag_dev(dev) returns a valid pointer before attempting to create the debugfs entries. Fixes: 7f46a0b7327a ("net/mlx5: Lag, add debugfs to query hardware lag state") Signed-off-by: Shay Drory Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan Link: https://patch.msgid.link/20260330194015.53585-2-tariqt@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c index b8feaf0f5c4c8..a372cb13aa08b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c @@ -163,8 +163,11 @@ DEFINE_SHOW_ATTRIBUTE(members); void mlx5_ldev_add_debugfs(struct mlx5_core_dev *dev) { + struct mlx5_lag *ldev = mlx5_lag_dev(dev); struct dentry *dbg; + if (!ldev) + return; dbg = debugfs_create_dir("lag", mlx5_debugfs_get_dev_root(dev)); dev->priv.dbg.lag_debugfs = dbg; -- 2.53.0