From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A97D337B81; Wed, 8 Apr 2026 18:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674402; cv=none; b=UYRdFXfHsv3ZapdPe41f7zukwR5so4XuWjugOLGaVShS0F5CVyg/zIrLV4zpkI/fvSardl+q+f82ofcvhSqq2z7ss0I/+VKZ6OgEhuwQvA4180cPIERj666pP6P6nl48C1w6b1olCMhjwtTke+cOe1ZohdzzA+3A8+dOjn3GJ4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674402; c=relaxed/simple; bh=SM7j62BYAPiM9wSeUPRkCvCWJXBVXN1ecVr4hesgj2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PhJFRDuzhGEfWX1VQcHPxvVk4t/8UqAwspgcXirgy15uBBGKoVnk8HwVJchZ3S7YQ2utYEbwY/C9Hg4DKdedZmzdI02qXWFek1EMKJrVud5/IEr9sntXQnWqw7L7Gb9TNm347x8UBnhMDmJ2IsJOTFmK29uD8CUNduruTybQjcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aL3T5DJF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aL3T5DJF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FF56C19421; Wed, 8 Apr 2026 18:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775674402; bh=SM7j62BYAPiM9wSeUPRkCvCWJXBVXN1ecVr4hesgj2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aL3T5DJFQtbDQQyhKZbMnGW1W5KMfqnbHZnup1tVbEttgVtFTB7zfa8kK0nCY+WV0 31RgfpLJ8jx82KnfcWoOp9opvhKPE+fW7NZJrRceUEW9QV3+Kw7l90oVAEcT4V9RNy OIBdufG34PURbRAF86ueGSDfHjmizDVSGUHx7SOQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yiming Qian , Florian Westphal , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 6.19 084/311] netfilter: nfnetlink_log: account for netlink header size Date: Wed, 8 Apr 2026 20:01:24 +0200 Message-ID: <20260408175942.549562098@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175939.393281918@linuxfoundation.org> References: <20260408175939.393281918@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Florian Westphal [ Upstream commit 6d52a4a0520a6696bdde51caa11f2d6821cd0c01 ] This is a followup to an old bug fix: NLMSG_DONE needs to account for the netlink header size, not just the attribute size. This can result in a WARN splat + drop of the netlink message, but other than this there are no ill effects. Fixes: 9dfa1dfe4d5e ("netfilter: nf_log: account for size of NLMSG_DONE attribute") Reported-by: Yiming Qian Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nfnetlink_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 27dd35224e629..dcd2493a9a404 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -726,7 +726,7 @@ nfulnl_log_packet(struct net *net, + nla_total_size(plen) /* prefix */ + nla_total_size(sizeof(struct nfulnl_msg_packet_hw)) + nla_total_size(sizeof(struct nfulnl_msg_packet_timestamp)) - + nla_total_size(sizeof(struct nfgenmsg)); /* NLMSG_DONE */ + + nlmsg_total_size(sizeof(struct nfgenmsg)); /* NLMSG_DONE */ if (in && skb_mac_header_was_set(skb)) { size += nla_total_size(skb->dev->hard_header_len) -- 2.53.0