From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52361337B81; Wed, 8 Apr 2026 18:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674415; cv=none; b=SWeZ2qmnWFOy0Ng8OJTxygB1vAmNh4H6TZvHekoNuGyNOMYESaWh96KBCU+7Nwkj4JRlMa8mW+qcMLscY7XWxUXzmqtvG8Yyj0txsn1Lm47bPVToos1MX6e51t+mQeCerUkjMimZsz+bmcfgFAKfSk/P7g7BNfFzNLWljs5Eq10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674415; c=relaxed/simple; bh=/6wfnpR8Q8hgALI+nIXR/BxFxWJd71XvtKKKVW+x8As=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R/cJZgccQDhxKPaqOrvgO2q/K1nRVOtRNUpll+zG6uOiqFx7PMsvjPx920pKaaKYMqJkG93s+uG6vh3tw9Xlc191FewI8f+GKNMlH8jMCefnadoa0jpalqd9hSxuMf3awIlhnnFCIctiJkkYEzQcreK9ekcH20zexg8p3JM+Js4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZN7I69KF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZN7I69KF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB626C19421; Wed, 8 Apr 2026 18:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775674415; bh=/6wfnpR8Q8hgALI+nIXR/BxFxWJd71XvtKKKVW+x8As=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZN7I69KFxuwDrFuMcXf90ZTIU4m8P/JlAu7FYUZjLphoGgBA/A6YWs/ZU18c1rzth Tdu3lYi7AtfojtNO7Va2hOi1Lix+TDQJxkod63Z5GpY7yRzOii9WVRdBEggyJlUcTH Q8ycluNuXI2C6j8gBa3eLi1l6HqjUuVcjIdowukM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Qi Tang , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 6.19 088/311] netfilter: ctnetlink: zero expect NAT fields when CTA_EXPECT_NAT absent Date: Wed, 8 Apr 2026 20:01:28 +0200 Message-ID: <20260408175942.699801554@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175939.393281918@linuxfoundation.org> References: <20260408175939.393281918@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qi Tang [ Upstream commit 35177c6877134a21315f37d57a5577846225623e ] ctnetlink_alloc_expect() allocates expectations from a non-zeroing slab cache via nf_ct_expect_alloc(). When CTA_EXPECT_NAT is not present in the netlink message, saved_addr and saved_proto are never initialized. Stale data from a previous slab occupant can then be dumped to userspace by ctnetlink_exp_dump_expect(), which checks these fields to decide whether to emit CTA_EXPECT_NAT. The safe sibling nf_ct_expect_init(), used by the packet path, explicitly zeroes these fields. Zero saved_addr, saved_proto and dir in the else branch, guarded by IS_ENABLED(CONFIG_NF_NAT) since these fields only exist when NAT is enabled. Confirmed by priming the expect slab with NAT-bearing expectations, freeing them, creating a new expectation without CTA_EXPECT_NAT, and observing that the ctnetlink dump emits a spurious CTA_EXPECT_NAT containing stale data from the prior allocation. Fixes: 076a0ca02644 ("netfilter: ctnetlink: add NAT support for expectations") Reported-by: kernel test robot Signed-off-by: Qi Tang Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_netlink.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index fea750653e967..3b5da5e7e9d27 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -3576,6 +3576,12 @@ ctnetlink_alloc_expect(const struct nlattr * const cda[], struct nf_conn *ct, exp, nf_ct_l3num(ct)); if (err < 0) goto err_out; +#if IS_ENABLED(CONFIG_NF_NAT) + } else { + memset(&exp->saved_addr, 0, sizeof(exp->saved_addr)); + memset(&exp->saved_proto, 0, sizeof(exp->saved_proto)); + exp->dir = 0; +#endif } return exp; err_out: -- 2.53.0