From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6003A34AB06; Wed, 8 Apr 2026 18:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674505; cv=none; b=AQ8rHKfDsLPHsip8s8nTVQjp8Vfjtn+85n/xV7S9iJEiWhEWbpv6IP5hvnxxdfn+lown/ECj0vGAFRQUjPJOBUq6MGcpoU5FkZ9KRk0JlIkwhBYyey9ru6B04wNkborrBQHgmB65UI+Z3gw+KHOAjWz3wv2+0u4ilmsei3degJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674505; c=relaxed/simple; bh=DrKfH3oW4ru6kUSapJ7eLZ7d3zcUcGIeN+/nYpiRYBA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SeGgi8AQWrYkG40ROlq6dzoGZYzIAV4FcrtqfRoEMbXh0STa4DspvcUJ4NnnXyzWj2y05DblhJvDPaBVxsUPaa3uPJVtwVXVygCmNeBKvP0hJowu+wGufoNJ0Y1bi1st4Uec9VwbeqklcbUfP+Dv0T/u2mlmseEWydcDCCqGTzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=x0ZB1BAp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="x0ZB1BAp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B135AC19421; Wed, 8 Apr 2026 18:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775674505; bh=DrKfH3oW4ru6kUSapJ7eLZ7d3zcUcGIeN+/nYpiRYBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x0ZB1BApSjliTn+af9NNP/OP7JUn8P6oRW+8SaPqmV5YenBCQnKpS1TiX3odmyE3p AL3pYaDpbhScB1laGzyOm0xjFwQuWnz2iKHnnuww8L+CWAU8mJ4Q8UtDrATTNOYXp3 jjGd3KhfLSyqaoJA0cmRgZP+q/rdkEk1cdYaLAKU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dimitri Daskalakis , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.19 123/311] eth: fbnic: Increase FBNIC_QUEUE_SIZE_MIN to 64 Date: Wed, 8 Apr 2026 20:02:03 +0200 Message-ID: <20260408175944.009129341@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175939.393281918@linuxfoundation.org> References: <20260408175939.393281918@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dimitri Daskalakis [ Upstream commit ec7067e661193403a7a00980bda8612db5954142 ] On systems with 64K pages, RX queues will be wedged if users set the descriptor count to the current minimum (16). Fbnic fragments large pages into 4K chunks, and scales down the ring size accordingly. With 64K pages and 16 descriptors, the ring size mask is 0 and will never be filled. 32 descriptors is another special case that wedges the RX rings. Internally, the rings track pages for the head/tail pointers, not page fragments. So with 32 descriptors, there's only 1 usable page as one ring slot is kept empty to disambiguate between an empty/full ring. As a result, the head pointer never advances and the HW stalls after consuming 16 page fragments. Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free") Signed-off-by: Dimitri Daskalakis Link: https://patch.msgid.link/20260401162848.2335350-1-dimitri.daskalakis1@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h index 51a98f27d5d91..f2ee2cbf3486b 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h @@ -38,7 +38,7 @@ struct fbnic_net; #define FBNIC_MAX_XDPQS 128u /* These apply to TWQs, TCQ, RCQ */ -#define FBNIC_QUEUE_SIZE_MIN 16u +#define FBNIC_QUEUE_SIZE_MIN 64u #define FBNIC_QUEUE_SIZE_MAX SZ_64K #define FBNIC_TXQ_SIZE_DEFAULT 1024 -- 2.53.0