From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6DA1F91D6; Wed, 8 Apr 2026 18:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674798; cv=none; b=oartxAu5jRy/Z+SGfHCswtghMnObvpHh66c1XzUpOfuIiNbyziH3WUBIsJbI82aqDt1R/yKOGscjMEnFkdWlI3ZURWuPZbJPfYdjtB2GnVbSuFyP895BQKjfIRLQvJoLno/6nJYynz6UqbkqSp1R4Dc1JdqZt/v+OlFIMDDbuT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674798; c=relaxed/simple; bh=nAW5wr7A3mKmpO9xbT/Qfhle7NJpBfqBZYvqA+UJ0/Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ux2SmtJhoSEGOVMpSD3W1mprPn7rNl+lr0Bt6pQPMHK0YIQ6AFerUe9eQyqOU67XC/UAQoa8juKsCugJDZDkpEerz9huGaiWA/l5a80JwFWkssuDuCiJrvPi03jAmNuZ1hr97EK5EMWZcR+VnKhl+vfbnPQhks4aufG7aDwGXLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jrPSoPg6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jrPSoPg6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12711C19421; Wed, 8 Apr 2026 18:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775674798; bh=nAW5wr7A3mKmpO9xbT/Qfhle7NJpBfqBZYvqA+UJ0/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jrPSoPg6uZyniI5PJ/NLEa3IqShBH9ZgroDeCSjwu5KH5tXGIU7hbpHxMYBqFJLRY wLDlMgpoXXND+gjpb8uWNslBRO0XLY77kJpK8ID77EE9khI9Iv+1CPMs0njm2t5OKa G3xDgQpvInh7sHcoDKG7Oa3onjIcm/dF1FS4Sk7U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bart Van Assche , Dmitry Torokhov Subject: [PATCH 6.19 210/311] Input: synaptics-rmi4 - fix a locking bug in an error path Date: Wed, 8 Apr 2026 20:03:30 +0200 Message-ID: <20260408175947.245536429@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175939.393281918@linuxfoundation.org> References: <20260408175939.393281918@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bart Van Assche commit 7adaaee5edd35a423ae199c41b86bd1ed60ed483 upstream. Lock f54->data_mutex when entering the function statement since jumping to the 'error' label when checking report_size fails causes that mutex to be unlocked. This bug has been detected by the Clang thread-safety checker. Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 diagnostics") Signed-off-by: Bart Van Assche Link: https://patch.msgid.link/20260223215118.2154194-16-bvanassche@acm.org Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/rmi4/rmi_f54.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -538,6 +538,8 @@ static void rmi_f54_work(struct work_str int error; int i; + mutex_lock(&f54->data_mutex); + report_size = rmi_f54_get_report_size(f54); if (report_size == 0) { dev_err(&fn->dev, "Bad report size, report type=%d\n", @@ -546,8 +548,6 @@ static void rmi_f54_work(struct work_str goto error; /* retry won't help */ } - mutex_lock(&f54->data_mutex); - /* * Need to check if command has completed. * If not try again later.