From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA743D9042; Wed, 8 Apr 2026 19:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674853; cv=none; b=HdZo3yb0/mULXFgKp5A3B3loFRBdiyqwp6OyEVHSBHWImoJ6uGQJvJ69S89YCyMbazjtKu2t1XS7qgANJImWCQR53+Q0oX/OWAd+Y5OVbucuT98v3+66Isop6GSMGl+xu3Pq2BA2hABFhUHlQ1fgvVxlRDIrUnttdqee0H37XoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674853; c=relaxed/simple; bh=wtWzoxnGCbaI96rY22+XLkPBe9cflemnjS3yGb/k/7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q/DXwpwMomg4M+RgfNoJOeMPFsYX8RLNbmLAJBeImvzPnV/1PnHuITSvuc+9XPREcy1hIkIgLAR1J8B04XELapIqYk0HeZmM4wIGtBsRUP/q1XiIYcZtE7JYgmReLmEfh/ZU9IDSMypAvujvxkwNMkHpi+/WNfII1GIIYMmCimM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AS7DddO5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AS7DddO5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00BA4C19421; Wed, 8 Apr 2026 19:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775674853; bh=wtWzoxnGCbaI96rY22+XLkPBe9cflemnjS3yGb/k/7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AS7DddO5/BF3lWnJvbYGjzUTFa1GfCfdrrJB9UEyxp1qoSTurYbXUgHMaUOU3zLnw Mc0dycEJaPFegqQMOPuFH5WDehgAjIhJFKiJQBDO8FxwS/ZQTvAb6JWmhw7ioAprOj K6dlEGkfdStzDu8PA1ShjrcMPrNokBv+oRMuihl0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Conor Dooley Subject: [PATCH 6.19 259/311] firmware: microchip: fail auto-update probe if no flash found Date: Wed, 8 Apr 2026 20:04:19 +0200 Message-ID: <20260408175949.057675137@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408175939.393281918@linuxfoundation.org> References: <20260408175939.393281918@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Conor Dooley commit c7596f9001e2b83293e3658e4e1addde69bb335d upstream. There's no point letting the driver probe if there is no flash, as trying to do a firmware upload will fail. Move the code that attempts to get the flash from firmware upload to probe, and let it emit a message to users stating why auto-update is not supported. The code currently could have a problem if there's a flash in devicetree, but the system controller driver fails to get a pointer to it from the mtd subsystem, which will cause mpfs_sys_controller_get_flash() to return an error. Check for errors and null, instead of just null, in the new clause. CC: stable@vger.kernel.org Fixes: ec5b0f1193ad4 ("firmware: microchip: add PolarFire SoC Auto Update support") Signed-off-by: Conor Dooley Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/microchip/mpfs-auto-update.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) --- a/drivers/firmware/microchip/mpfs-auto-update.c +++ b/drivers/firmware/microchip/mpfs-auto-update.c @@ -113,10 +113,6 @@ static enum fw_upload_err mpfs_auto_upda * be added here. */ - priv->flash = mpfs_sys_controller_get_flash(priv->sys_controller); - if (!priv->flash) - return FW_UPLOAD_ERR_HW_ERROR; - erase_size = round_up(erase_size, (u64)priv->flash->erasesize); /* @@ -427,6 +423,12 @@ static int mpfs_auto_update_probe(struct return dev_err_probe(dev, PTR_ERR(priv->sys_controller), "Could not register as a sub device of the system controller\n"); + priv->flash = mpfs_sys_controller_get_flash(priv->sys_controller); + if (IS_ERR_OR_NULL(priv->flash)) { + dev_dbg(dev, "No flash connected to the system controller, auto-update not supported\n"); + return -ENODEV; + } + priv->dev = dev; platform_set_drvdata(pdev, priv);