public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Robert Garcia <rob_garcia@163.com>,
	stable@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
	io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.15.y] io_uring/tctx: work around xa_store() allocation error issue
Date: Wed, 8 Apr 2026 14:51:24 +0200	[thread overview]
Message-ID: <2026040818-staunch-clicker-c988@gregkh> (raw)
In-Reply-To: <c0e7718f-7bec-44b5-966d-46149fe30507@kernel.dk>

On Mon, Mar 23, 2026 at 07:37:24AM -0600, Jens Axboe wrote:
> On 3/23/26 2:19 AM, Robert Garcia wrote:
> > From: Jens Axboe <axboe@kernel.dk>
> > 
> > [ Upstream commit 7eb75ce7527129d7f1fee6951566af409a37a1c4 ]
> > 
> > syzbot triggered the following WARN_ON:
> > 
> > WARNING: CPU: 0 PID: 16 at io_uring/tctx.c:51 __io_uring_free+0xfa/0x140 io_uring/tctx.c:51
> > 
> > which is the
> > 
> > WARN_ON_ONCE(!xa_empty(&tctx->xa));
> > 
> > sanity check in __io_uring_free() when a io_uring_task is going through
> > its final put. The syzbot test case includes injecting memory allocation
> > failures, and it very much looks like xa_store() can fail one of its
> > memory allocations and end up with ->head being non-NULL even though no
> > entries exist in the xarray.
> > 
> > Until this issue gets sorted out, work around it by attempting to
> > iterate entries in our xarray, and WARN_ON_ONCE() if one is found.
> > 
> > Reported-by: syzbot+cc36d44ec9f368e443d3@syzkaller.appspotmail.com
> > Link: https://lore.kernel.org/io-uring/673c1643.050a0220.87769.0066.GAE@google.com/
> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
> > [ Modify the function in io_uring.c because it's located here in v5.15. ]
> > Signed-off-by: Robert Garcia <rob_garcia@163.com>
> 
> I'm find adding this to 5.15 stable. However, this also need to go to
> 5.10-stable then as the io_uring bases are identical. Greg, when you
> queue this up, please add to both. Thanks!

Now done, thanks.

greg k-h

      reply	other threads:[~2026-04-08 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  8:19 [PATCH 5.15.y] io_uring/tctx: work around xa_store() allocation error issue Robert Garcia
2026-03-23 13:37 ` Jens Axboe
2026-04-08 12:51   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026040818-staunch-clicker-c988@gregkh \
    --to=greg@kroah.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob_garcia@163.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox