From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4A173BB9FC; Thu, 9 Apr 2026 12:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775736326; cv=none; b=nvjxT8IfNzRJ81M2nxR26oLYJC/ZZoPsOrpkF+HwopeZ7Y7WkEHGDuTC+aM/ttSQrVkeB8YkgwL4vfRfhp6PVCC5acNC5aXus81yP0UKtu4BuSMqiFj9ZcH7TONms8Es0rNAFxwx43rHA6kHZ8S4bkqOQFL7Gfr6X0CSnK0ME0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775736326; c=relaxed/simple; bh=2uxiTHf7+/Jq9Yfc9KZLO7wTUuJPnmq2OheP+99yRUM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=arq77VjadJPK/2QLpQF0STOWoTa13dhiw3yroMV7DHUbNEgwzAGz2ghbP4qRT7sAzgEJJmQGmNT/o5h8euCnUlsVPoO0axqyHpmNSDcRxhDGJbq6ImznwyoGLx4EE3TC7vC7dKZbDDINiedSoGeFUdj+mgDN1A38FkHc1BASe6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n/rBVe8w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n/rBVe8w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E3B6C2BCB8; Thu, 9 Apr 2026 12:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775736326; bh=2uxiTHf7+/Jq9Yfc9KZLO7wTUuJPnmq2OheP+99yRUM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n/rBVe8wc6VfAWlBoPfgX8EzDkI9BQK8Wwp4cxxpBvtNR3bieUGR7Oy++nCM0qMyu AIv4HefHJn95pz79VMahvHbvOVpJDaNRaZnYruEBSd9m7Gz8wTLLHhJ8DrtcgrM4NM acY0HfoXUHvjYcaVdrfKX9ri3wHY1davvVxeG8MlQVcvqwqpm8LaBI/8DmCt6ie4sK 4YjlLY50fII1BijPt18AU+4qOTkFGTRbcKxqDOBGeLmlIgSbJM+HMUbuVZjRBPglht a2bmBkZesYVUp/kdp4r0C+erKDXEw/XfgjHvS7UeF+LP3a058ewCpl8Pr/B3V7gEmH LTynMjDiYfofw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wAo8S-00000001d7H-0YU0; Thu, 09 Apr 2026 14:05:24 +0200 From: Johan Hovold To: Mark Brown Cc: Sunny Luo , Xianwei Zhao , Chin-Ting Kuo , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Radu Pirea , William Zhang , Kursad Oney , Jonas Gorski , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Prajna Rajendra Kumar Subject: [PATCH 19/20] spi: microchip-core-spi: fix controller deregistration Date: Thu, 9 Apr 2026 14:04:18 +0200 Message-ID: <20260409120419.388546-20-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260409120419.388546-1-johan@kernel.org> References: <20260409120419.388546-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before disabling underlying resources like interrupts during driver unbind. Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller") Cc: stable@vger.kernel.org # 6.19 Cc: Prajna Rajendra Kumar Signed-off-by: Johan Hovold --- drivers/spi/spi-microchip-core-spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-microchip-core-spi.c b/drivers/spi/spi-microchip-core-spi.c index a4c128ae391b..be01c178e2b0 100644 --- a/drivers/spi/spi-microchip-core-spi.c +++ b/drivers/spi/spi-microchip-core-spi.c @@ -384,7 +384,7 @@ static int mchp_corespi_probe(struct platform_device *pdev) mchp_corespi_init(host, spi); - ret = devm_spi_register_controller(dev, host); + ret = spi_register_controller(host); if (ret) { mchp_corespi_disable_ints(spi); mchp_corespi_disable(spi); @@ -399,6 +399,8 @@ static void mchp_corespi_remove(struct platform_device *pdev) struct spi_controller *host = platform_get_drvdata(pdev); struct mchp_corespi *spi = spi_controller_get_devdata(host); + spi_unregister_controller(host); + mchp_corespi_disable_ints(spi); mchp_corespi_disable(spi); } -- 2.52.0