From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB1B35B632; Thu, 9 Apr 2026 08:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775724241; cv=none; b=u+9Idx/YqNDhymfs7jafz1fWJRx/h9yBmm8qSIr3lIdw8ZUWV8J9VPzvWwAx2epj60rM8krxFFoiZDZokL7eKoDPTS/XskAOLNUv2SloaiBLTKBNZxQ1q1SCOws1TElhaOeZp767B0G1v9EIIJjc42z6Wd7ie6sScTyCO93nAbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775724241; c=relaxed/simple; bh=c3l40ewtFhAAKx9acG4lHqPI/H4SJGEpItzWEJ5dkBc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EiSvhEUK8VGFmTryMPX7sJM377zFsp51On7+LvYTucekPsjPKSXLwvSXHN7VsY45sTkpUSOHaiKQfttT0/l2/vAs6XMivYESqc1PDX3b4V8+9gUuQigPED7HCJGwVaQDoN6GFx/688pcg5m1lqQjxyi8iQqsRjtHiPrshhnWGYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HcXqhFp4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HcXqhFp4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E67E2C19424; Thu, 9 Apr 2026 08:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775724241; bh=c3l40ewtFhAAKx9acG4lHqPI/H4SJGEpItzWEJ5dkBc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HcXqhFp4peq/l+366VlKu/y+mO69z8GYwTCJUrzT1mbbxePEqnhqBgkmgexvJ/d4O jmQN4RJVFgAIDzFg76ZGt3c6iTtKZ0YlNcZcgZhvEoORh8Lg1rRAQs8OREMFQTd57q tRZO9lKG8yDgzkiVb2PSC+hxMkLW+q6/TTt0mUzQ= Date: Thu, 9 Apr 2026 10:43:58 +0200 From: Greg Kroah-Hartman To: Jiri Slaby Cc: stable@vger.kernel.org, patches@lists.linux.dev, Dmitry Torokhov , Ingo Molnar , "Rafael J. Wysocki" , Andy Shevchenko , Daniel Scally , Danilo Krummrich , Hans de Goede , Heikki Krogerus , Sakari Ailus Subject: Re: [PATCH 6.19 248/311] x86/platform/geode: Fix on-stack property data use-after-return bug Message-ID: <2026040941-surviving-surgery-189a@gregkh> References: <20260408175939.393281918@linuxfoundation.org> <20260408175948.651696885@linuxfoundation.org> <2026040926-pregnancy-altitude-5d24@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2026040926-pregnancy-altitude-5d24@gregkh> On Thu, Apr 09, 2026 at 10:26:55AM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 09, 2026 at 10:09:59AM +0200, Jiri Slaby wrote: > > Hi, > > > > On 08. 04. 26, 20:04, Greg Kroah-Hartman wrote: > > > 6.19-stable review patch. If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Dmitry Torokhov > > > > > > commit b981e9e94c687b7b19ae8820963f005b842cb2f2 upstream. > > ... > > > --- a/arch/x86/platform/geode/geode-common.c > > > +++ b/arch/x86/platform/geode/geode-common.c > > ... > > > @@ -127,6 +129,12 @@ int __init geode_create_leds(const char > > > goto err_free_swnodes; > > > } > > > + gpio_refs = kzalloc_objs(*gpio_refs, n_leds); > > > > On x86_32, this fails to build: > > arch/x86/platform/geode/geode-common.c:132:21: error: implicit declaration > > of function ‘kzalloc_objs’; did you mean ‘kzalloc_node’? > > [-Wimplicit-function-declaration] > > arch/x86/platform/geode/geode-common.c:132:19: error: assignment to ‘struct > > software_node_ref_args *’ from ‘int’ makes pointer from integer without a > > cast [-Wint-conversion] > > 132 | gpio_refs = kzalloc_objs(*gpio_refs, n_leds); > > > > > > 6.19 does not have kzalloc_objs() yet. > > Ugh, yeah, Sasha caught this too, let me go fix this up, my fault. I > guess I never build x32 kernels anymore :( Ok, now fixed up, I'll go push out new -rc2 releases with this fix in it to make sure I didn't get it wrong. thanks, greg k-h