From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 633A33AE195; Fri, 10 Apr 2026 08:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; cv=none; b=a69PEoL6PA65Z7cEpgewCozPgEPp2NSEN2Uw/ll2MrAAoBeAEdksWA2R4D52WAXYK5WYf/TkN8Y4+zN2paHx57CAy1/TeAEMimIsO8w5wPja3IRma7/Y2t4z6OCMY2T6HKXRA1UtJn+bLHIqs0nFpTqSTLRpdBdzaqKwJqgAzNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; c=relaxed/simple; bh=E6LBLCR9Dx3gSdjYmZz7WjDYYx7rCmY0rROSyfTrtP4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rASePTcjt5k7jNer39dX/MFeOBSKTdPa6C3NXsEBEn7E+dlJsIOIz56xqfnpSYkNcbnMkFbB1YbYkgqYw+TkKZvTKduqWptVwMFCJWBiIp4SX9GqQmdPfZOxpBfhPQxO15Pyzh8aet3BANrdah2nc8nrCAUBIpBxoHYaXDziwzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fwc4QKB1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fwc4QKB1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1D5EC4AF17; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775809136; bh=E6LBLCR9Dx3gSdjYmZz7WjDYYx7rCmY0rROSyfTrtP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fwc4QKB1kX1ut7Zz8ytYLXknCbJB8YGFYvDHyyyCVv4H5XK61yctFPDF8E9oeCjPL xfxPuWMqltLIVXAC30fIWD4eZqEzNOsfjfbMIB0sBG+gA5dSrytjFdaprRLoTz9UvE 5BIXEoHnQSSY68wG2CfutrNKM+OTEfkfapl1JrLV5cZXQ8InWC0Jqy203AbOD2Blvc mvYW8qkia4fz29JCfW+BaCg8Sbd1UObIpUgenwpCiQylwNziuvxsFhLLtaq6dSbKwg Rwa6QkzepTpCijFODcsnAmTMrFAz0JzT++tA9hyrEzclCOCgXfCTXKqGW9zSDumgOS x79ICshpekAHw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wB74n-000000026uq-4Bbt; Fri, 10 Apr 2026 10:18:54 +0200 From: Johan Hovold To: Mark Brown Cc: Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Linus Walleij , Andi Shyti , Tudor Ambarus , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Jernej Skrabec , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Maxime Ripard Subject: [PATCH 18/26] spi: sun4i: fix controller deregistration Date: Fri, 10 Apr 2026 10:17:48 +0200 Message-ID: <20260410081757.503099-19-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260410081757.503099-1-johan@kernel.org> References: <20260410081757.503099-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b5f6517948cc ("spi: sunxi: Add Allwinner A10 SPI controller driver") Cc: stable@vger.kernel.org # 3.15 Cc: Maxime Ripard Signed-off-by: Johan Hovold --- drivers/spi/spi-sun4i.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index bfdf419a583c..b7fbb5270edb 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -504,7 +504,7 @@ static int sun4i_spi_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); pm_runtime_idle(&pdev->dev); - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&pdev->dev, "cannot register SPI host\n"); goto err_pm_disable; @@ -522,7 +522,15 @@ static int sun4i_spi_probe(struct platform_device *pdev) static void sun4i_spi_remove(struct platform_device *pdev) { + struct spi_controller *host = platform_get_drvdata(pdev); + + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_force_suspend(&pdev->dev); + + spi_controller_put(host); } static const struct of_device_id sun4i_spi_match[] = { -- 2.52.0