From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71AAD3AE6F8; Fri, 10 Apr 2026 08:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; cv=none; b=X1dAoaf+TibSJzglhSJGgILUm0JeLOUsI+Q5T4+89s6GNcDVA1RoxwpZG41hrhX6Id3kWf9cleSY+ltztuZ8LOOdB0xUYjztmKvDMGicpWqu6rqeNNJLP59L3WBvTBDzspFu3zEyOg8ZJ1J4rNejOpEfQLBfrWRte62SzxzwWh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; c=relaxed/simple; bh=C8UBH5bPbrlP3dh1Dls2keMpeyV18D6q87El/jPrm+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=frK38lTK8/nTDNx1BsQ+ArnFw0fTLsUbXkjWO928VsnNwFMZ/TryU+XUvBb6+UQHIA2kfEREYvcoLR07dLmf9JBwbithpp3hkZ2qHwIoz1TjqxyL/9lrRvB90iwtHFJThySqaX3v6QGwheQKMF2s3UtKO9tJCezKnZcUt8ouvT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RXdSHc3n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RXdSHc3n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0851C4AF54; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775809136; bh=C8UBH5bPbrlP3dh1Dls2keMpeyV18D6q87El/jPrm+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RXdSHc3nXMFmKJz5w5pIFPMzOLzJ9YGRnbY/KcyUGXCNEJsi+J0oSzDmmfb+AhE3n 0YsuFHlTKVezIh7ZAmDhHkDVxkf0GSSEA6hp2Elgh+LDXVLNhuQBPFh50GKGtb7fDf 2YjqzmeG5rlMhi2YI7FQTn6Bfb0JMjAAq9wOjbCxlCZGDBCgwBPAIm6HQL6ggXs7N4 6n8H8Ol9FlEjAk9yh3eLkTvoMUt4+c1H4zIeB6D1LTwaMU/T7NJ6soukejd2pr49NG cDUxZye7f9CRPlOrvvKuakuk6JsVp048hsCySvelHMhSZdD893qiIVCkAqEVErJQ7m boVC53rSNOTZA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wB74o-000000026uu-04rK; Fri, 10 Apr 2026 10:18:54 +0200 From: Johan Hovold To: Mark Brown Cc: Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Linus Walleij , Andi Shyti , Tudor Ambarus , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Jernej Skrabec , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Masahisa Kojima Subject: [PATCH 20/26] spi: syncuacer: fix controller deregistration Date: Fri, 10 Apr 2026 10:17:50 +0200 Message-ID: <20260410081757.503099-21-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260410081757.503099-1-johan@kernel.org> References: <20260410081757.503099-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b0823ee35cf9 ("spi: Add spi driver for Socionext SynQuacer platform") Cc: stable@vger.kernel.org # 5.3 Cc: Masahisa Kojima Signed-off-by: Johan Hovold --- drivers/spi/spi-synquacer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c index d0a875249910..290c439897c4 100644 --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -716,7 +716,7 @@ static int synquacer_spi_probe(struct platform_device *pdev) pm_runtime_set_active(sspi->dev); pm_runtime_enable(sspi->dev); - ret = devm_spi_register_controller(sspi->dev, host); + ret = spi_register_controller(host); if (ret) goto disable_pm; @@ -737,9 +737,15 @@ static void synquacer_spi_remove(struct platform_device *pdev) struct spi_controller *host = platform_get_drvdata(pdev); struct synquacer_spi *sspi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(sspi->dev); clk_disable_unprepare(sspi->clk); + + spi_controller_put(host); } static int __maybe_unused synquacer_spi_suspend(struct device *dev) -- 2.52.0