From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD773A4F5D; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809136; cv=none; b=T5SvgphLLpZmOrt24MPPBs3uoLfK90SPWOPGP9LLGghyln8JJzHMh8yuhHk/s5rrvCD/WW5I7+f3fF5AtWOR+V2GsbockQMuhLaYbw93zpP5pp862yE3RcHLFVcpCeSV1I+0iiFuSHS0U1diJUQ9n40FFLBaG/JjS+6hiW0Cc3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809136; c=relaxed/simple; bh=3MDk07ELTLc65ElB0/PDIBO0H49pzu5s9K4oCp6KKiA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WBlBok+4Ytrc8nsqDw/7qDbRoVGDOCi0rJ82LC1YrqMFVUoCETGqU1sXit6a8eZhU/BL0XekZ/s1XaE4S0+7WCqIHGQGXr1CJPyMfJnlYIJZD4/OujnwtB/blBU5oGHa7j94wncjRQtHe/4JZJm3X6RDx+jPMl/t7sgFwHu7k7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KqtvDjcR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KqtvDjcR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F37BC2BC87; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775809136; bh=3MDk07ELTLc65ElB0/PDIBO0H49pzu5s9K4oCp6KKiA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KqtvDjcR5DUtlu3tVa27NZjpInIoluawh+JxExFpcDbHIGYD9M9RbC+pU2EpNyaju OxF0HypCH1s+pc9zIA3jnCcOCQvl3Z5g6w9WqgQhc/D1Q/yMEtHIIOtY0/iNpdent2 GFFWtTe9sTFvCAs+bSAdBWx85ao95DUKMT7ERbg2XlX1mMxuCj+Gpc04j1w27+9QV+ c69ehgEZrSwfhJPjVabIIva7lLX6G8MulL8UhO5YhEHHDrBILDJ0i/ZX9oSX0Wbjyv AwmYIAeFVdPIEnad+7nZXC0RsAsy3s5WQr+PhRiknFKSQGOunmLPZDeUs8hCtkpkCU iTQybTzIUpawQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wB74n-000000026uM-3Xas; Fri, 10 Apr 2026 10:18:53 +0200 From: Johan Hovold To: Mark Brown Cc: Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Linus Walleij , Andi Shyti , Tudor Ambarus , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Jernej Skrabec , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Jingoo Han Subject: [PATCH 03/26] spi: mxs: fix controller deregistration Date: Fri, 10 Apr 2026 10:17:33 +0200 Message-ID: <20260410081757.503099-4-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260410081757.503099-1-johan@kernel.org> References: <20260410081757.503099-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 33e195acf268 ("spi: mxs: use devm_spi_register_master()") Cc: stable@vger.kernel.org # 3.13 Cc: Jingoo Han Signed-off-by: Johan Hovold --- drivers/spi/spi-mxs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index b3301c69e2de..0164e04d59a1 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -619,7 +619,7 @@ static int mxs_spi_probe(struct platform_device *pdev) if (ret) goto out_pm_runtime_put; - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&pdev->dev, "Cannot register SPI host, %d\n", ret); goto out_pm_runtime_put; @@ -650,11 +650,17 @@ static void mxs_spi_remove(struct platform_device *pdev) spi = spi_controller_get_devdata(host); ssp = &spi->ssp; + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) mxs_spi_runtime_suspend(&pdev->dev); dma_release_channel(ssp->dmach); + + spi_controller_put(host); } static struct platform_driver mxs_spi_driver = { -- 2.52.0