From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1382D3ACA62; Fri, 10 Apr 2026 08:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; cv=none; b=IrHPjpnRspLXykCgN/VqtDYoiibhqRuf5Slli9xwqA+qKNMCjbUol1fVDzYK3qCOys/WUZ6Xyswcgk3ssaYOgolEtWqkKEEk8kVSuUa/55PS84mpS0bf6mhVwJgWPGXjfGXxdszz54ChFjCW0Njak6re7EVEyQ9f024zARk0XNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; c=relaxed/simple; bh=XAJF9Dgd3KEivhPnAw48nGC8xHdyG9h1Y+3SmIViMdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DLoTXdrm2wIiMk2TXljpHFPCIhETVec0CXI5ABVI/CrW5qBdd5Os84RS1iNqYbmndr2bQCXEuS+X+DHGlnium3WLIqVRd4Ew/lsDYzaKM6FQ/OGNaH2byeIwzwaFYyRq1CJM5/MqYMRpWEgJ62RI4giiphIpvoi+EJQKFuKcDw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hQotE9dV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hQotE9dV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC3AC2BC9E; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775809136; bh=XAJF9Dgd3KEivhPnAw48nGC8xHdyG9h1Y+3SmIViMdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hQotE9dVhzgpJLRHqDWAFXWaR21yRt7U0zxc6K6r1tKvxZFn6abnH3CPj3SOMwOdw nKNXa/UaOZnTpE6y8HL7PoCWFU+HCYOciHbov3LLF7W8OG++IeRvWn2t0BXCcc63qf sM0M3GCHtQUEadMp3WPDzDBZUpbC6tzA7Cr+bHV2SEHjpkl1+pHwJVQv0UrYSQP8G4 AirA+8alDEUP0f71WqoDRQfna7/+dCJDPC46QpHfE6KvFrdTCNMb/uC96CXCOiO55h 6TzBs6emJB8UVq/NL/PfNKoq8ROa4XFttlbLCmil5EE04HBk65zNbaASgpOR0gM6I1 gApf0fifZDfsw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wB74n-000000026uS-3fj8; Fri, 10 Apr 2026 10:18:53 +0200 From: Johan Hovold To: Mark Brown Cc: Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Linus Walleij , Andi Shyti , Tudor Ambarus , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Jernej Skrabec , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Purna Chandra Mandal Subject: [PATCH 06/26] spi: pic32: fix controller deregistration Date: Fri, 10 Apr 2026 10:17:36 +0200 Message-ID: <20260410081757.503099-7-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260410081757.503099-1-johan@kernel.org> References: <20260410081757.503099-1-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 1bcb9f8ceb67 ("spi: spi-pic32: Add PIC32 SPI master driver") Cc: stable@vger.kernel.org # 4.7 Cc: Purna Chandra Mandal Signed-off-by: Johan Hovold --- drivers/spi/spi-pic32.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index 369850d14313..70427e529945 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -821,7 +821,7 @@ static int pic32_spi_probe(struct platform_device *pdev) } /* register host */ - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&host->dev, "failed registering spi host\n"); goto err_bailout; @@ -840,11 +840,16 @@ static int pic32_spi_probe(struct platform_device *pdev) static void pic32_spi_remove(struct platform_device *pdev) { - struct pic32_spi *pic32s; + struct pic32_spi *pic32s = platform_get_drvdata(pdev); + + spi_controller_get(pic32s->host); + + spi_unregister_controller(pic32s->host); - pic32s = platform_get_drvdata(pdev); pic32_spi_disable(pic32s); pic32_spi_dma_unprep(pic32s); + + spi_controller_put(pic32s->host); } static const struct of_device_id pic32_spi_of_match[] = { -- 2.52.0