From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH 1/2] gpib: Remove useless code
Date: Sat, 11 Apr 2026 12:20:24 +0200 [thread overview]
Message-ID: <20260411102025.2000-2-dpenkler@gmail.com> (raw)
In-Reply-To: <20260411102025.2000-1-dpenkler@gmail.com>
This code is a hangover from an earlier approach in the
driver where the driver modules were called gpibXX
It no longer serves any purpose.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/gpib/common/gpib_os.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpib/common/gpib_os.c b/drivers/gpib/common/gpib_os.c
index 2b4ec6aa893b..fca181b8c749 100644
--- a/drivers/gpib/common/gpib_os.c
+++ b/drivers/gpib/common/gpib_os.c
@@ -544,13 +544,6 @@ int ibopen(struct inode *inode, struct file *filep)
priv = filep->private_data;
init_gpib_file_private((struct gpib_file_private *)filep->private_data);
- if (board->use_count == 0) {
- int retval;
-
- retval = request_module("gpib%i", minor);
- if (retval)
- dev_dbg(board->gpib_dev, "request module returned %i\n", retval);
- }
if (board->interface) {
if (!try_module_get(board->provider_module)) {
dev_err(board->gpib_dev, "try_module_get() failed\n");
--
2.53.0
next prev parent reply other threads:[~2026-04-11 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 10:20 [PATCH 0/2] gpib: cleanup and fix error code Dave Penkler
2026-04-11 10:20 ` Dave Penkler [this message]
2026-04-11 10:20 ` [PATCH 2/2] gpib: Fix inappropriate ioctl error return Dave Penkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411102025.2000-2-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox