From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH 3/6] gpib: Don't use extended registers
Date: Sat, 11 Apr 2026 19:25:08 +0200 [thread overview]
Message-ID: <20260411172511.26546-4-dpenkler@gmail.com> (raw)
In-Reply-To: <20260411172511.26546-1-dpenkler@gmail.com>
When the chip type is 72310 then avoid accessing extended registers
Apart from the BSR the 72310 supports only the standard NEC u7210
registers.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/gpib/ines/ines_gpib.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpib/ines/ines_gpib.c b/drivers/gpib/ines/ines_gpib.c
index dd98cb261a4c..df299a9d7f4d 100644
--- a/drivers/gpib/ines/ines_gpib.c
+++ b/drivers/gpib/ines/ines_gpib.c
@@ -103,6 +103,9 @@ static int ines_t1_delay(struct gpib_board *board, unsigned int nano_sec)
retval = nec7210_t1_delay(board, nec_priv, nano_sec);
+ if (ines_priv->pci_chip_type == PCI_CHIP_INES_72130)
+ return retval;
+
if (nano_sec <= 250) {
write_byte(nec_priv, INES_AUXD | INES_FOLLOWING_T1_250ns |
INES_INITIAL_T1_2000ns, AUXMR);
@@ -322,6 +325,8 @@ static irqreturn_t ines_interrupt(struct gpib_board *board)
spin_lock_irqsave(&board->spinlock, flags);
nec7210_interrupt(board, nec_priv);
+ if (priv->pci_chip_type == PCI_CHIP_INES_72130)
+ goto out;
isr3_bits = ines_inb(priv, ISR3);
isr4_bits = ines_inb(priv, ISR4);
if (isr3_bits & IFC_ACTIVE_BIT) {
@@ -339,6 +344,7 @@ static irqreturn_t ines_interrupt(struct gpib_board *board)
if (wake)
wake_up_interruptible(&board->wait);
+out:
spin_unlock_irqrestore(&board->spinlock, flags);
return IRQ_HANDLED;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-11 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 17:25 [PATCH 0/6] gpib: Add support for ines pci_xl board Dave Penkler
2026-04-11 17:25 ` [PATCH 1/6] gpib: Add enums for INES 72130 based cards Dave Penkler
2026-04-11 17:25 ` [PATCH 2/6] gpib: Add ines 72130 line_status routine Dave Penkler
2026-04-11 17:25 ` Dave Penkler [this message]
2026-04-11 17:25 ` [PATCH 4/6] gpib: Add ines_pci_xl_interface Dave Penkler
2026-04-11 17:25 ` [PATCH 5/6] gpib: Add attach routine for pci_xl board Dave Penkler
2026-04-11 17:25 ` [PATCH 6/6] gpib; Add register and unregister calls Dave Penkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411172511.26546-4-dpenkler@gmail.com \
--to=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox