From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9153822B3 for ; Mon, 13 Apr 2026 04:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776053647; cv=none; b=KRUhVJN45CneLdGUMgHJoav09S41lRwTa5WNf5AStdI7Y+1+C+RntYZ2ERkx1FKo5CFP6hdNriNBSYUkGQk7GG+GqD951JSal+b6aC4wqBkzprOT7fIrGCQ0vuuI5XCuuer8AdT9oesajrFBpWEwdKe0xfGwkzC69RqZFLyjF6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776053647; c=relaxed/simple; bh=RNRVJrYmqG5YlmX8NduMldnF09efBUPi4P4Sq07qN7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W9kO3unZChWe3Cwc0w5IefqMff1MQgqJLwEmNHbtSYBFRhRiAKBVxCKiBce/yZnRndY54Z6mrXDtGxTU33RwspDwcBUbr1glH5vqf8WFbmHbka5Ll0XXpleiOStr2pEtXuhPBdGa1YdIHAiu3mLes0AAfWiiBpKF+7t6yBHyir4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eRS1DAfh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eRS1DAfh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7E39C116C6; Mon, 13 Apr 2026 04:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776053647; bh=RNRVJrYmqG5YlmX8NduMldnF09efBUPi4P4Sq07qN7o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eRS1DAfhK0w54dukoq1pAC5K9z2Tq0lEhxQC398QRddk7gYUDwzQtpFwVvg2VQeie /KWsyTWoNvHw0Snubu2bnqPhP3WmWJfufJ2EZDq0M1xblCkvyfDlYzEdNc5kAnBwoJ 1i1XPjCZdb0CL04gt4bdNnkRc6lTJHPORD+P3Db1XRvJ85od2S6jtiMEHi5lO1Us4Y IncHTpWChmIvfJDdc7SYy3SIsLSlWik74QZVrl0JE60hv2+luyIKGKGSThLexBzORI NGc7DGI6Ta/BdBiVOp5kAZgue50SQQqrIFX7CStuPkKAYXBtaV4IbBniQJOI9BVAv3 z+4+SgIUrAuBw== From: Sasha Levin To: Robert Garcia Cc: Sasha Levin , stable@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 5.15.y] block: fix resource leak in blk_register_queue() error path Date: Mon, 13 Apr 2026 00:14:05 -0400 Message-ID: <20260412120103.block-blk-register-queue@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409063616.117503-1-rob_garcia@163.com> References: <20260409063616.117503-1-rob_garcia@163.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > [PATCH 5.15.y] block: fix resource leak in blk_register_queue() > error path This patch places blk_mq_sysfs_unregister(q) on the success path (after kobject_uevent, before 'ret = 0') rather than on the error path. As written, this would unregister sysfs on every successful blk_register_queue() call, breaking block device initialization.