From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96783382F1 for ; Sun, 12 Apr 2026 12:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775995880; cv=none; b=CrvVg/g0TRhxGhCpAgxEA8+GEgl6PusTdY1kUdjBTYQjZ4YFh6lSl80QM7on8d78uuEgVsvxkD0+VRo7aozkvNxTiO7r7tiXBRhJVJ7TmsFImcFEvbBDgR171fXsL0EZQbn7Qe6mFCTZDHw2Q/Csyy2VNI0OuoHQITTOZ1Fvuo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775995880; c=relaxed/simple; bh=ZyKw8wUOUn5OuInmSBqYcBDG/vqNSPfWkN+wrqufmx0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N9Fi9/9tqlhLXJD0EExO+4HF8ZtBgV0+32QhLJ55dTzqe0yL9XeTYfNZNHPPU2ManL3rHMLBXMRrBBCGEJEJI2Dkqh5Q5/uthtWBFKYtPYgZFcPYRTRWIADQmVMXSVVYGiJxMKZzer7UoLZcMwd0eRsyYfQTCOn8/QpQIrDasdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iT5Niv06; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iT5Niv06" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB2D4C19424; Sun, 12 Apr 2026 12:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775995880; bh=ZyKw8wUOUn5OuInmSBqYcBDG/vqNSPfWkN+wrqufmx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iT5Niv06U02CNXgbuIH38ox6ofFp9Z7N0I7n/jOeaG/SSbWZwfOrCT/v5GClYvr9R lh2XCRQLS+E/wI3hAELUD1qvB+VG12lB67EpzIhnXPfwa/cAxMdZ0mHTvcXsAGXICs BD4gU4S1cdnGkI7ttb95ejnWQQyKVyxxcaCxzzAeDdfPjGkZQxDUjwdLyoOUpw9wOU MDfOugXDm+XK5TitXYy5fu7RMrJPqvI/JosgBtJMj61jcj05lZ2SMNSfUu4NjSJXWz ZFLo3Q2LgkpUV9r4RDJKy3ghV9smCG2jWkdwMfrwGgB4mCIsmupdEpYx3i34POW/cW zKF19YLMElPCg== From: Sasha Levin To: stable@vger.kernel.org Cc: Michael Zimmermann , stable , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.10.y] usb: gadget: f_hid: move list and spinlock inits from bind to alloc Date: Sun, 12 Apr 2026 08:11:18 -0400 Message-ID: <20260412121118.2103786-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026040828-repaying-spherical-743f@gregkh> References: <2026040828-repaying-spherical-743f@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Michael Zimmermann [ Upstream commit 4e0a88254ad59f6c53a34bf5fa241884ec09e8b2 ] There was an issue when you did the following: - setup and bind an hid gadget - open /dev/hidg0 - use the resulting fd in EPOLL_CTL_ADD - unbind the UDC - bind the UDC - use the fd in EPOLL_CTL_DEL When CONFIG_DEBUG_LIST was enabled, a list_del corruption was reported within remove_wait_queue (via ep_remove_wait_queue). After some debugging I found out that the queues, which f_hid registers via poll_wait were the problem. These were initialized using init_waitqueue_head inside hidg_bind. So effectively, the bind function re-initialized the queues while there were still items in them. The solution is to move the initialization from hidg_bind to hidg_alloc to extend their lifetimes to the lifetime of the function instance. Additionally, I found many other possibly problematic init calls in the bind function, which I moved as well. Signed-off-by: Michael Zimmermann Cc: stable Link: https://patch.msgid.link/20260331184844.2388761-1-sigmaepsilon92@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/function/f_hid.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index c285b23c3707c..e3738a1aa9f48 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -996,13 +996,8 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f) if (status) goto fail; - spin_lock_init(&hidg->write_spinlock); hidg->write_pending = 1; hidg->req = NULL; - spin_lock_init(&hidg->read_spinlock); - init_waitqueue_head(&hidg->write_queue); - init_waitqueue_head(&hidg->read_queue); - INIT_LIST_HEAD(&hidg->completed_out_req); /* create char device */ cdev_init(&hidg->cdev, &f_hidg_fops); @@ -1272,6 +1267,12 @@ static struct usb_function *hidg_alloc(struct usb_function_instance *fi) mutex_lock(&opts->lock); ++opts->refcnt; + spin_lock_init(&hidg->write_spinlock); + spin_lock_init(&hidg->read_spinlock); + init_waitqueue_head(&hidg->write_queue); + init_waitqueue_head(&hidg->read_queue); + INIT_LIST_HEAD(&hidg->completed_out_req); + device_initialize(&hidg->dev); hidg->dev.release = hidg_release; hidg->dev.class = hidg_class; -- 2.53.0