From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC0782C0F6D for ; Mon, 13 Apr 2026 11:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776079888; cv=none; b=kB1OBWFlTkMB4yQxZHMgsw0k2Iz9+uB/v/B6lLnrkK8FP92EQFNtbrhdSieRcUaNemBJoK9guhxeqC7ju3L9Inv3kb9LKj/6eizCpyRfcTpNx3EU3U7G2ui2fPMXMSVVa0B/zoCRplD7kgq94E1cJPy15Tw7DqEqttnAdxXaQ7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776079888; c=relaxed/simple; bh=DbVXFzZyjAoVeJHskZ1L0eh18MtWBJ4jGV+rreaw/s0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OQpIR+yChVadSSyb6AohIjH7ZubHYR2abRr6ab48NV5HfwiFTlfpbu0QHkiTl+JxFTlRrH2T+AwsrBYaRYTI6Cof1sxiS9yw1QQXcOAkasPLmAUASCiKF60nqsBAuGLC0v66yo/yEwXZSQLqh7GscYi4TaUc0crXQDLSfFmO2eU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MOYocntj; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MOYocntj" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82f431c0ab6so301981b3a.0 for ; Mon, 13 Apr 2026 04:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776079887; x=1776684687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y/It8wJpFq48iLElY6BoKRmtjgHX5ES0T9yGLlkbn8w=; b=MOYocntjYxXsd6g86Z+bIpSZBqs/1+7IJSYOvKWo/gPgys9wIooQdC0Kkoo7EuR5Cr 2QcntVRXJqwnHDirKcxBh4F2K4RvCN74RbMGPgKXZKnsDkt2SqBbFF+i1FR2U30xA6QP eqeCc4jou4Un98grJQ1W1zmVOBgooh8OEq8TbP3/5hqVywiG0UfjEmDkpxwoEy+kuaqG 3w8PsLI0A6icPsKwI+5Vi7glS+OPkybcBPiTgjQvDOOsK62cHREFtKZc9mDNRZhaIAJY iR7HjkkF2+RgQ9Y9hINAfB+54q2KUejq+sozneHDurBA6MBFVV2A/r42N8bkbmR9vP2O ZwkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776079887; x=1776684687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y/It8wJpFq48iLElY6BoKRmtjgHX5ES0T9yGLlkbn8w=; b=jJ75VuB0V3ZluhuWHErqzppb8WLZsHgxpzsu7vqKlBuVdN0zJPiSU5Ppbiw2azU1D3 c5+w9vkbYj48zq0vbweXfygoHfthe5ne+rHHKdYVsf+dI+qCG9RLFQHNrx0ko2w7j9ZG RLd25mNs5gcY/qyo3o0vO3H0JW75R12nXWOQUKcKPdGg/a1CQUNZdmv1YAz3eyBUzjd4 R/VGuK6gbyE1yyy6cKZOUqYksL9hKk8X9kQy+4iuCJMbiZyWi8KdkuyLvLZDmvy1vu2q 5wufTe6WabVKdD2jbQsYgVhpka+eq5+OjpW8LYu5RzTYCusNUi9nswS9e+TsUehz4M3+ M8cw== X-Forwarded-Encrypted: i=1; AFNElJ+y2GX8+oC3NHkYudOwasqHaVooz10rBicmsCS5RZJlZ2Aj5XlpIxAzpjccqzOCvXzhKLp5GuM=@vger.kernel.org X-Gm-Message-State: AOJu0YwyPEMR01zPXyzOLwdGZzlRMf6wM4bcq03RPkOlMeJ9G5lGUY9r E9X6busqUUZZC2C7uJhXfwA6nOHx8WQEKnVLbp9Nl/1m82JKkn6pbo/Z X-Gm-Gg: AeBDievyBjeUv6dkdgtJ5sUmNG22LUGq+piB65IY1NlmQfOAqn47LeO+BmBcaNc72+7 7iBqq/xPXS8WcmH2xxc2/9iOc3uq27lXf1Umt/nIi6tGW855xVcL0Zpwu26bmlr0cCOLdPIWYTs qTj4GbSq3Fpzb5U8JYJQldIQvE0ptFR0CXiUNW8BOGvxBt5qhf4ac+oXYRAhag1k1OclmNcWNLS xTJ3Fkd+QvBL44qW/gTL7nknYVbk29kzzZJpNSXsW+m9mwqupp70Pcxjcfj/VZ39VLQ+RRdDdJh 9dxlOgRXWXtb7uWLmWamF3fQ0mE8cxS339wM69K/i8U9eWK6UV4z2f/kDe9E9ONNOuTmnxRs0NE pN1tjj3yKa0N3REaHev8sG1G3KpKEiwxHqL9erRT72FH9rLeTzaL8ZU7+oflC6ouVkKEQJ4Vva4 oeWLcpo90vLWbc9hD5PtAF4CuO3VMdx3RJ X-Received: by 2002:a05:6a00:114f:b0:82c:e0d7:2681 with SMTP id d2e1a72fcca58-82f0c276ff3mr13615144b3a.16.1776079886925; Mon, 13 Apr 2026 04:31:26 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c36130csm11037040b3a.24.2026.04.13.04.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 04:31:26 -0700 (PDT) From: Guangshuo Li To: Vinicius Costa Gomes , Dave Jiang , Vinod Koul , Fenghua Yu , Shuai Xue , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] dmaengine: idxd: fix double free in idxd_alloc() error path Date: Mon, 13 Apr 2026 19:31:13 +0800 Message-ID: <20260413113113.2725940-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When dev_set_name() fails after device_initialize(), idxd_alloc() calls put_device(conf_dev). For these devices, conf_dev->type is set from idxd->data->dev_type, which resolves to dsa_device_type or iax_device_type, and both use idxd_conf_device_release() as their release callback. That release callback frees idxd, idxd->opcap_bmap, and releases idxd->id, but the current error path then frees those resources again directly, causing a double free. The issue was identified by a static analysis tool I developed and confirmed by manual review. Keep the cleanup in idxd_conf_device_release() after put_device() and avoid freeing idxd-managed resources again in idxd_alloc(). Fixes: 46a5cca76c76 ("dmaengine: idxd: fix memory leak in error handling path of idxd_alloc") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/dma/idxd/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index f1bd9812c90d..20505e14ef9f 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -631,7 +631,7 @@ static struct idxd_device *idxd_alloc(struct pci_dev *pdev, struct idxd_driver_d err_name: put_device(conf_dev); - bitmap_free(idxd->opcap_bmap); + return NULL; err_opcap: ida_free(&idxd_ida, idxd->id); err_ida: -- 2.43.0