From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48A33313298; Mon, 13 Apr 2026 16:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099006; cv=none; b=EkEB14iAEm023sMwtHWsx9XA0qUAuNT+fYgq/Xfg9bammzaLGj9eMF04fhIL3njURB2h6ZV3w21wlqrkyHfEQ6Ujlw1pRGxkoFJWTtHDcirP+gd1IuJnN//d+6v8cpF/6prZai/dY/YJ2z0UsWm6NEZpgA127VnZTnEbW1o0/Fg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099006; c=relaxed/simple; bh=OwcCtigsL3yPIk7qQPfPQIsR/ZMLs9Yg7qzftE2jSdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Xs40lCs+Tq10OApBByvL8PHDjiRdaitp01eNuPtiqfIMnbDT2dDI5EkErN2V5ja2CGLkAXPhhOOrnml5LWKEjx+TP8cb9DvvuBE3Be6owtGZXz9H4TkYJXFCISBKqjdUdENCaIE4BE8iSFR9If/vQGWdkpX0PapfXKefFujT6Z0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z5d0gm0C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z5d0gm0C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6E88C2BCAF; Mon, 13 Apr 2026 16:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099006; bh=OwcCtigsL3yPIk7qQPfPQIsR/ZMLs9Yg7qzftE2jSdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5d0gm0CPYQ1c64HF4izs/uNhaTXkhamUkEQAWujdLoVbrbIbe1MxtITDn5/nYLgi 1lWQiIzSgE73jt1yGPRmij7qsOCGDxxds2rSS5zvuCNk6HN+s6I6EtnWaQYA1GXq5z DBc2qd2wiyGmOROpUXCHjCFZGcENHnJQD4duhLlA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ma=C3=ADra=20Canal?= , Florian Fainelli , Stefan Wahren , Ulf Hansson , Sasha Levin Subject: [PATCH 5.10 172/491] pmdomain: bcm: bcm2835-power: Fix broken reset status read Date: Mon, 13 Apr 2026 17:56:57 +0200 Message-ID: <20260413155825.486078717@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maíra Canal [ Upstream commit 550bae2c0931dbb664a61b08c21cf156f0a5362a ] bcm2835_reset_status() has a misplaced parenthesis on every PM_READ() call. Since PM_READ(reg) expands to readl(power->base + (reg)), the expression: PM_READ(PM_GRAFX & PM_V3DRSTN) computes the bitwise AND of the register offset PM_GRAFX with the bitmask PM_V3DRSTN before using the result as a register offset, reading from the wrong MMIO address instead of the intended PM_GRAFX register. The same issue affects the PM_IMAGE cases. Fix by moving the closing parenthesis so PM_READ() receives only the register offset, and the bitmask is applied to the value returned by the read. Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") Signed-off-by: Maíra Canal Reviewed-by: Florian Fainelli Reviewed-by: Stefan Wahren Cc: stable@vger.kernel.org Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/soc/bcm/bcm2835-power.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/soc/bcm/bcm2835-power.c +++ b/drivers/soc/bcm/bcm2835-power.c @@ -566,11 +566,11 @@ static int bcm2835_reset_status(struct r switch (id) { case BCM2835_RESET_V3D: - return !PM_READ(PM_GRAFX & PM_V3DRSTN); + return !(PM_READ(PM_GRAFX) & PM_V3DRSTN); case BCM2835_RESET_H264: - return !PM_READ(PM_IMAGE & PM_H264RSTN); + return !(PM_READ(PM_IMAGE) & PM_H264RSTN); case BCM2835_RESET_ISP: - return !PM_READ(PM_IMAGE & PM_ISPRSTN); + return !(PM_READ(PM_IMAGE) & PM_ISPRSTN); default: return -EINVAL; }