Re: [PATCH 5.10 153/491] gve: defer interrupt enabling until NAPI registration

Ben Hutchings
2026-04-15T10:22:24Z

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

On Mon, 2026-04-13 at 17:56 +0200, Greg Kroah-Hartman wrote:
> 5.10-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Ankit Garg <nktgrg@google.com>
>
> commit 3d970eda003441f66551a91fda16478ac0711617 upstream.
[...]
> --- a/drivers/net/ethernet/google/gve/gve_main.c
> +++ b/drivers/net/ethernet/google/gve/gve_main.c
[...]
> @@ -420,6 +422,7 @@ static void gve_remove_napi(struct gve_p
> struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];
>
> netif_napi_del(&block->napi);
> + disable_irq(block->irq);

The disable_irq() belongs before the netif_napi_del(). (The upstream
version got this right.)

Ben.

> }
>
> static int gve_register_qpls(struct gve_priv *priv)
>
>

--
Ben Hutchings
The obvious mathematical breakthrough [to break modern encryption]
would be development of an easy way to factor large prime numbers.
- Bill Gates

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]