From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADA6931715D; Mon, 13 Apr 2026 16:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099142; cv=none; b=s6d/ZHKqKUOum6Gt7OeXqks+HvbGFMZDyeeRNLn59NeFoPaA1emNIzlReBfigNU8b7wB/AxVpkTATgcaNRzNvetQjvy/GnklXpYq/oxDONifr72b6TkQSe1aUevxZZJPFbiHK0slo8CDGZP19ge6vru4Xz81v/TYAnskuY4h1eQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099142; c=relaxed/simple; bh=pimFCI53UhMi8llsYpIN7FcTr8LhAk7jLfFxVaW2oAA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AOeX1sSeHQUWINg1Ln+w5dlBUJRBv7suGD3Q+M3wMBzIaGqtIrj6OrhcxORQFiNiTdMTzP2v1kAwaPRbJIvEdcQPCzDSz40gX3yDjDTL5eIk4WGmtuVuZx54csPQfE+FA+vtH8BVZRi3DYCxup0N4OQ8fXTck1v0vfDoDcmNX6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lCCxYjKR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lCCxYjKR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43808C2BCAF; Mon, 13 Apr 2026 16:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099142; bh=pimFCI53UhMi8llsYpIN7FcTr8LhAk7jLfFxVaW2oAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lCCxYjKRMspjGlJIkBGCAE8UZK3HGIFyDxPcc1YMJ8bJF0nJeCV650cofUOK6WHRK qFARVTo6hC0+b4oRnning2DhZUdFL7s90+K8c1CU2nYOkO06GOLAES8cZM7T6seeTp pfCzjp5iB3H983j2hL4sM5M6TcQXvLmTLSlwPmJ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sanman Pradhan , Guenter Roeck Subject: [PATCH 5.10 227/491] hwmon: (pmbus/isl68137) Fix unchecked return value and use sysfs_emit() Date: Mon, 13 Apr 2026 17:57:52 +0200 Message-ID: <20260413155827.558774039@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sanman Pradhan commit 86259558e422b250aa6aa57163a6d759074573f5 upstream. isl68137_avs_enable_show_page() uses the return value of pmbus_read_byte_data() without checking for errors. If the I2C transaction fails, a negative error code is passed through bitwise operations, producing incorrect output. Add an error check to propagate the return value if it is negative. Additionally, modernize the callback by replacing sprintf() with sysfs_emit(). Fixes: 038a9c3d1e424 ("hwmon: (pmbus/isl68137) Add driver for Intersil ISL68137 PWM Controller") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan Link: https://lore.kernel.org/r/20260318193952.47908-2-sanman.pradhan@hpe.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/pmbus/isl68137.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/hwmon/pmbus/isl68137.c +++ b/drivers/hwmon/pmbus/isl68137.c @@ -80,8 +80,11 @@ static ssize_t isl68137_avs_enable_show_ { int val = pmbus_read_byte_data(client, page, PMBUS_OPERATION); - return sprintf(buf, "%d\n", - (val & ISL68137_VOUT_AVS) == ISL68137_VOUT_AVS ? 1 : 0); + if (val < 0) + return val; + + return sysfs_emit(buf, "%d\n", + (val & ISL68137_VOUT_AVS) == ISL68137_VOUT_AVS); } static ssize_t isl68137_avs_enable_store_page(struct i2c_client *client,