From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADA1331E846; Mon, 13 Apr 2026 16:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099295; cv=none; b=Pezfr7lqrfQ98Wfx9dTFbdw26qfvDJoMnlxnZvJ4jVk5Gfiv3kpLZIJm0FN81qqENEV5Q8nWEwMFjOHbPSmrpnu5NEGZDzRNTPD2HzZy+nqBkGP2sxJakQ6jjZfyI5ZDP3tCRAYI60fuPhW7OxMPaQxo7WjxvlA2z5kAOd5TKaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099295; c=relaxed/simple; bh=i75o3YCfjVk4LagfWNiCaZq6Hr+oYkBTUQ4BgxnQfaQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eHU/1EiCgRrO3ZB5grMSLxL1yhjgMmUVXwan6SUUukKLm0UNql+VT0kxaVkxI0X7HZHyaqfgg2eE7/u9h0/BK2wjobRkBxhLn9KbwDKJzs7LdfJDYFNim+uCJIPqYfkzsbhmFau65Q9u46N5k6Qda3iWm99FISsHiNztPg6huX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bpPNeXrM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bpPNeXrM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5984C2BCB0; Mon, 13 Apr 2026 16:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099295; bh=i75o3YCfjVk4LagfWNiCaZq6Hr+oYkBTUQ4BgxnQfaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bpPNeXrM1PysBw/3HtqaDg07kb3A7Lo3eaGM7nbrefplhtEVx79Aa+xJTG+IjOguS jhhEeVyAIqy9OSuuiOiKMpyeh4g/ra4VZecte8VelmfnmWqCom7svqymwZQCE7EUa+ RjXczN5ekCQJvJJavdeCbazKekJfNf34siZTXY+g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mark Brown , Sasha Levin Subject: [PATCH 5.10 244/491] ASoC: fsl_easrc: Fix event generation in fsl_easrc_iec958_put_bits() Date: Mon, 13 Apr 2026 17:58:09 +0200 Message-ID: <20260413155828.191955962@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Brown [ Upstream commit 54a86cf48eaa6d1ab5130d756b718775e81e1748 ] ALSA controls should return 1 if the value in the control changed but the control put operation fsl_easrc_iec958_put_bits() unconditionally returns 0, causing ALSA to not generate any change events. This is detected by mixer-test with large numbers of messages in the form: No event generated for Context 3 IEC958 CS5 Context 3 IEC958 CS5.0 orig 5224 read 5225, is_volatile 0 Add a suitable check. Signed-off-by: Mark Brown Link: https://patch.msgid.link/20260205-asoc-fsl-easrc-fix-events-v1-1-39d4c766918b@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_easrc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index 52b3f2d44f681..6af5c1735e2ed 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c @@ -52,10 +52,13 @@ static int fsl_easrc_iec958_put_bits(struct snd_kcontrol *kcontrol, struct soc_mreg_control *mc = (struct soc_mreg_control *)kcontrol->private_value; unsigned int regval = ucontrol->value.integer.value[0]; + int ret; + + ret = (easrc_priv->bps_iec958[mc->regbase] != regval); easrc_priv->bps_iec958[mc->regbase] = regval; - return 0; + return ret; } static int fsl_easrc_iec958_get_bits(struct snd_kcontrol *kcontrol, -- 2.51.0