From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D7F83161BF; Mon, 13 Apr 2026 16:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099248; cv=none; b=O6Wph+QzJ+NRt06B+znSFL4yqyMKgMpHz3cTyol3T34mJe7PFMWMr2pJmfV+3HyCb7KTyF9GrXZsWt8XyvcM5RICtn7QLJg3/yelb9kgqOfRzjErxz+r4RePqwOVnw0q6tLcTz+0BmwVl3aIzMG6aJcS2MPC6sQ2u1lVvKyWgUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099248; c=relaxed/simple; bh=dKV7OrXXeuQ9VvKAeIGZEJeZkSKwN7VmymMmwcQNrvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BJmhB45ccUfJCDGKRI6X5lSr06RZBZTe7roeEWBS68JWmE4pqpiMom99fPbTdqtD/l/4oSYqq105lP4WOYP92wY7xuMTjs/2nAc1SZLmJT4BfgIvPrd/KZsVS0XrusQ9MHQ6EKrFnnVAEgE813foN3sPVlrI18+5eI4TAg5Vc7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Dyn8orRy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Dyn8orRy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 162B5C2BCAF; Mon, 13 Apr 2026 16:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099248; bh=dKV7OrXXeuQ9VvKAeIGZEJeZkSKwN7VmymMmwcQNrvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dyn8orRyzjKgrkLF61aoejDI5wcdcBEoYkkUEaJ5g5jtJ2SkOfW5XtyuHfxp6ndzU CnKzcGtCf9pH3mLqUV4EENvw0V8RMXrNt+AgmO2lJ+mSsZ8ce0zGzBloJsALrJy/ZU MvWOGBs6WS6ysV5/6YXjYKnsaIQm85WEC4vVBBHw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Mei , Weiming Shi , Florian Westphal , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.10 267/491] netfilter: nfnetlink_log: fix uninitialized padding leak in NFULA_PAYLOAD Date: Mon, 13 Apr 2026 17:58:32 +0200 Message-ID: <20260413155829.047639824@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weiming Shi [ Upstream commit 52025ebaa29f4eb4ed8bf92ce83a68f24ab7fdf7 ] __build_packet_message() manually constructs the NFULA_PAYLOAD netlink attribute using skb_put() and skb_copy_bits(), bypassing the standard nla_reserve()/nla_put() helpers. While nla_total_size(data_len) bytes are allocated (including NLA alignment padding), only data_len bytes of actual packet data are copied. The trailing nla_padlen(data_len) bytes (1-3 when data_len is not 4-byte aligned) are never initialized, leaking stale heap contents to userspace via the NFLOG netlink socket. Replace the manual attribute construction with nla_reserve(), which handles the tailroom check, header setup, and padding zeroing via __nla_reserve(). The subsequent skb_copy_bits() fills in the payload data on top of the properly initialized attribute. Fixes: df6fb868d611 ("[NETFILTER]: nfnetlink: convert to generic netlink attribute functions") Reported-by: Xiang Mei Signed-off-by: Weiming Shi Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nfnetlink_log.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 80c09070ea9fa..3a71ba47224c4 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -632,15 +632,11 @@ __build_packet_message(struct nfnl_log_net *log, if (data_len) { struct nlattr *nla; - int size = nla_attr_size(data_len); - if (skb_tailroom(inst->skb) < nla_total_size(data_len)) + nla = nla_reserve(inst->skb, NFULA_PAYLOAD, data_len); + if (!nla) goto nla_put_failure; - nla = skb_put(inst->skb, nla_total_size(data_len)); - nla->nla_type = NFULA_PAYLOAD; - nla->nla_len = size; - if (skb_copy_bits(skb, 0, nla_data(nla), data_len)) BUG(); } -- 2.51.0