From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74DCB3203B6; Mon, 13 Apr 2026 16:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099509; cv=none; b=PSJoahIk0Mt+HySq+NlNncMighCfeyU6IpP2/Dr9B/GuQaCNSJyigBJCM/DiLW8vTrAB/q7CET/5ET+Viav91BAkte8efOzcspvoX19dkG/XCoB8L2vjo8SpX8M6gPWw2aIFPJ6f1kxO2LeJLz6L6n2dOMLGnmvNicqtSDLZevU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099509; c=relaxed/simple; bh=rGSHVZDHV9Wbrzwg8eSoWKIT2Nkbl9OFO6jWmtF8mM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZsoOQJA+gzd6tef/8Pqz1/QcxyiE0/OChFKitW3h0D6C/md5u5SRFSoXpBXmIjDHtYBQm9APAlxKUs3H6wJ16zVJjzJS/Slpq+A1EleVGSqCMrJq/JN2fGig2s2T/Jn5Pm66MNihbB4dEZeHnJLoFy8wIin2jt3wcnntlp9hMpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=O2BmKD39; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="O2BmKD39" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F405CC2BCAF; Mon, 13 Apr 2026 16:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776099509; bh=rGSHVZDHV9Wbrzwg8eSoWKIT2Nkbl9OFO6jWmtF8mM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O2BmKD39ZHCmbbGc0Vj8trsjnIeRu4hpNyBA6yj9u9Tl7zptnfbogrUgD0nSrFPlc UYNnQduTFTQoQ1XKKibEFp+xzjlYXL5toOPlu6AKrj5nkYyLoCejqzIipkKkiTLc0D SexuoHO1k99QVzj5eRTtVUxi3TnwPgt0+3N5wH9s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yiming Qian , Martin Schiller , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 350/491] net/x25: Fix overflow when accumulating packets Date: Mon, 13 Apr 2026 17:59:55 +0200 Message-ID: <20260413155832.142573212@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155819.042779211@linuxfoundation.org> References: <20260413155819.042779211@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Martin Schiller [ Upstream commit a1822cb524e89b4cd2cf0b82e484a2335496a6d9 ] Add a check to ensure that `x25_sock.fraglen` does not overflow. The `fraglen` also needs to be resetted when purging `fragment_queue` in `x25_clear_queues()`. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Suggested-by: Yiming Qian Signed-off-by: Martin Schiller Link: https://patch.msgid.link/20260331-x25_fraglen-v4-2-3e69f18464b4@dev.tdt.de Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/x25/x25_in.c | 4 ++++ net/x25/x25_subr.c | 1 + 2 files changed, 5 insertions(+) diff --git a/net/x25/x25_in.c b/net/x25/x25_in.c index 77ad186507f64..956e056803079 100644 --- a/net/x25/x25_in.c +++ b/net/x25/x25_in.c @@ -34,6 +34,10 @@ static int x25_queue_rx_frame(struct sock *sk, struct sk_buff *skb, int more) struct sk_buff *skbo, *skbn = skb; struct x25_sock *x25 = x25_sk(sk); + /* make sure we don't overflow */ + if (x25->fraglen + skb->len > USHRT_MAX) + return 1; + if (more) { x25->fraglen += skb->len; skb_queue_tail(&x25->fragment_queue, skb); diff --git a/net/x25/x25_subr.c b/net/x25/x25_subr.c index 0285aaa1e93c1..159708d9ad20c 100644 --- a/net/x25/x25_subr.c +++ b/net/x25/x25_subr.c @@ -40,6 +40,7 @@ void x25_clear_queues(struct sock *sk) skb_queue_purge(&x25->interrupt_in_queue); skb_queue_purge(&x25->interrupt_out_queue); skb_queue_purge(&x25->fragment_queue); + x25->fraglen = 0; } -- 2.53.0