From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD3B8225A38; Mon, 13 Apr 2026 16:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097821; cv=none; b=EK3Yz08ZoiMYAALYmsEt5EmAKC8f5Kx7ueWxUuru7ZHYiiKkE1a0vOsKyuKAFZMzrspSEUPoKHUDjE2BTYJqXKoRsa2FWKZ+i+S133cIKsTmn9kJQF9PGmQNw26UPbHEmqNOFsbJX+OhuYplf6CC7OPN96dn6WnJuEns9MHA/ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097821; c=relaxed/simple; bh=eDoVV6XvAgEREnA5tBgUxZIB3v/EeRt1Tc/82dl+q2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L9xGvkAIrY+0++JKr2qJROkepJtcqDowC1ENk82r4tfbvpHrO9aDYMvBtkpGsiuZUtgQU7mMrfFWSrRvUxXDLSLLRoOaCwsxdQp5n5VF+zn3qGHZ/HdsT0gPJnvRAqGGwqPsv38K4O1TFunqBpRB9qC+I9mQBRCZwC7T9rY8Vpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1EAR/a2o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1EAR/a2o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C944C2BCAF; Mon, 13 Apr 2026 16:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776097821; bh=eDoVV6XvAgEREnA5tBgUxZIB3v/EeRt1Tc/82dl+q2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1EAR/a2oqMC4tU7YqO9XfDaNVKAh5idsMdB0PsBSpfFot4ee1HUxUKFVv7xKZRccN 73Jdqvbd6UK8oDzZUkYQKXjfj+ZbfghzO8jvqdcqu2pPPIIQtU9wn6eTd6LzljkdCW dLXpyvasSres5VLMFJhOPnVHlE8O/xElxp8juUWo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kamal Dasu , William Zhang , Miquel Raynal , Sasha Levin Subject: [PATCH 5.15 285/570] mtd: rawnand: serialize lock/unlock against other NAND operations Date: Mon, 13 Apr 2026 17:56:56 +0200 Message-ID: <20260413155841.167869708@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413155830.386096114@linuxfoundation.org> References: <20260413155830.386096114@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kamal Dasu [ Upstream commit bab2bc6e850a697a23b9e5f0e21bb8c187615e95 ] nand_lock() and nand_unlock() call into chip->ops.lock_area/unlock_area without holding the NAND device lock. On controllers that implement SET_FEATURES via multiple low-level PIO commands, these can race with concurrent UBI/UBIFS background erase/write operations that hold the device lock, resulting in cmd_pending conflicts on the NAND controller. Add nand_get_device()/nand_release_device() around the lock/unlock operations to serialize them against all other NAND controller access. Fixes: 92270086b7e5 ("mtd: rawnand: Add support for manufacturer specific lock/unlock operation") Signed-off-by: Kamal Dasu Reviewed-by: William Zhang Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/nand_base.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index ee8f47feeaf43..60ad72392b9f8 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -4680,11 +4680,16 @@ static void nand_shutdown(struct mtd_info *mtd) static int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) { struct nand_chip *chip = mtd_to_nand(mtd); + int ret; if (!chip->ops.lock_area) return -ENOTSUPP; - return chip->ops.lock_area(chip, ofs, len); + nand_get_device(chip); + ret = chip->ops.lock_area(chip, ofs, len); + nand_release_device(chip); + + return ret; } /** @@ -4696,11 +4701,16 @@ static int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) static int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) { struct nand_chip *chip = mtd_to_nand(mtd); + int ret; if (!chip->ops.unlock_area) return -ENOTSUPP; - return chip->ops.unlock_area(chip, ofs, len); + nand_get_device(chip); + ret = chip->ops.unlock_area(chip, ofs, len); + nand_release_device(chip); + + return ret; } /* Set default functions */ -- 2.51.0