From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931CA24DCF6 for ; Mon, 13 Apr 2026 16:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097577; cv=none; b=PzeLUDAQBq3ehYYrjPwzcDgCqwOesmfInZGiEIkmNBeCNcOGlahKju2V+WfLG4IuMKusPn6aCGEDLZHYOKD+oNtC72so2F/tcmTGfforiNfq4wV0vAFvJwnVK2gHr6oCEH5OmCltTYvgktEyQK1NIbdSYArHafKWIhAizOLT2EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097577; c=relaxed/simple; bh=ku5kBJGrDtVHrtkqwrLLkEDE5VnoWjS5tgcNBzwwTOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eDwKoNe4suVHKOwl+DiLbwiEUWZGsRWasgbNm324Ahk0daXfvmC487vFNAmJhZyqa3vWWeTF5bfMDj519CEwoaI5KGWwfDEFHeu/ypLSPutFaosemqzvczoa26XAqP1Hr5+IID/OuhbLOpQ/1C6U8H7YdB5JCUa0uf7ChH+DXRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DJ6WLgGp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DJ6WLgGp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57D98C2BCB0; Mon, 13 Apr 2026 16:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776097577; bh=ku5kBJGrDtVHrtkqwrLLkEDE5VnoWjS5tgcNBzwwTOo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DJ6WLgGpkcJhsB0HZEj+mdahvG5meE2OyLcFdpyuSLBHrjYRlAZL/zSU2cixnwQuQ V46Hl34DdN7c/PrVq7VmTTim76V38AXEg3EASZmgLT1QmdVL8gRdXrY3rQeRmrB669 CXIhDVRzTYJApd96+ExPltpwBFuImUHnWi5YmuAWZE8ol/bjtvndFpn6zBI1h4r8xv i6/f5Cd89xotG7dr8Dl9bAc/50G+YUE/dismjJ23BBJRWcKA3ULQwX/639qL4nAAf4 V3eqi9EH5h2GvtDJFYopI2JJQxCgXkOqREgxE5gqLAlpgTyWyl4W2Z/6TYw7Exi9jA MqyuYOqyN5rgw== From: Sasha Levin To: stable@vger.kernel.org Cc: Joseph Qi , syzbot+62c1793956716ea8b28a@syzkaller.appspotmail.com, Mark Fasheh , Joel Becker , Junxiao Bi , Changwei Ge , Jun Piao , Heming Zhao , Andrew Morton , Sasha Levin Subject: [PATCH 5.10.y 3/3] ocfs2: fix out-of-bounds write in ocfs2_write_end_inline Date: Mon, 13 Apr 2026 12:26:11 -0400 Message-ID: <20260413162611.3289109-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413162611.3289109-1-sashal@kernel.org> References: <2026041354-dork-imperial-5aba@gregkh> <20260413162611.3289109-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Joseph Qi [ Upstream commit 7bc5da4842bed3252d26e742213741a4d0ac1b14 ] KASAN reports a use-after-free write of 4086 bytes in ocfs2_write_end_inline, called from ocfs2_write_end_nolock during a copy_file_range splice fallback on a corrupted ocfs2 filesystem mounted on a loop device. The actual bug is an out-of-bounds write past the inode block buffer, not a true use-after-free. The write overflows into an adjacent freed page, which KASAN reports as UAF. The root cause is that ocfs2_try_to_write_inline_data trusts the on-disk id_count field to determine whether a write fits in inline data. On a corrupted filesystem, id_count can exceed the physical maximum inline data capacity, causing writes to overflow the inode block buffer. Call trace (crash path): vfs_copy_file_range (fs/read_write.c:1634) do_splice_direct splice_direct_to_actor iter_file_splice_write ocfs2_file_write_iter generic_perform_write ocfs2_write_end ocfs2_write_end_nolock (fs/ocfs2/aops.c:1949) ocfs2_write_end_inline (fs/ocfs2/aops.c:1915) memcpy_from_folio <-- KASAN: write OOB So add id_count upper bound check in ocfs2_validate_inode_block() to alongside the existing i_size check to fix it. Link: https://lkml.kernel.org/r/20260403063830.3662739-1-joseph.qi@linux.alibaba.com Signed-off-by: Joseph Qi Reported-by: syzbot+62c1793956716ea8b28a@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=62c1793956716ea8b28a Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Cc: Heming Zhao Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/ocfs2/inode.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index a673d877291c7..bf5100e7f9e08 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1429,6 +1429,16 @@ int ocfs2_validate_inode_block(struct super_block *sb, goto bail; } + if (le16_to_cpu(data->id_count) > + ocfs2_max_inline_data_with_xattr(sb, di)) { + rc = ocfs2_error(sb, + "Invalid dinode #%llu: inline data id_count %u exceeds max %d\n", + (unsigned long long)bh->b_blocknr, + le16_to_cpu(data->id_count), + ocfs2_max_inline_data_with_xattr(sb, di)); + goto bail; + } + if (le64_to_cpu(di->i_size) > le16_to_cpu(data->id_count)) { rc = ocfs2_error(sb, "Invalid dinode #%llu: inline data i_size %llu exceeds id_count %u\n", -- 2.53.0