public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Charles Xu <charles_xu@189.cn>
Cc: wei.fang@nxp.com, vladimir.oltean@nxp.com, kuba@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 6.1.y] net: enetc: VFs do not support HWTSTAMP_TX_ONESTEP_SYNC
Date: Mon, 13 Apr 2026 14:04:48 +0200	[thread overview]
Message-ID: <2026041329-recovery-disjoin-b370@gregkh> (raw)
In-Reply-To: <20260413032322.4206-1-charles_xu@189.cn>

On Mon, Apr 13, 2026 at 11:23:22AM +0800, Charles Xu wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> [ Upstream commit a562d0c4a893eae3ea51d512c4d90ab858a6b7ec ]
> 
> Actually ENETC VFs do not support HWTSTAMP_TX_ONESTEP_SYNC because only
> ENETC PF can access PMa_SINGLE_STEP registers. And there will be a crash
> if VFs are used to test one-step timestamp, the crash log as follows.
> 
> [  129.110909] Unable to handle kernel paging request at virtual address 00000000000080c0
> [  129.287769] Call trace:
> [  129.290219]  enetc_port_mac_wr+0x30/0xec (P)
> [  129.294504]  enetc_start_xmit+0xda4/0xe74
> [  129.298525]  enetc_xmit+0x70/0xec
> [  129.301848]  dev_hard_start_xmit+0x98/0x118
> 
> Fixes: 41514737ecaa ("enetc: add get_ts_info interface for ethtool")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Link: https://patch.msgid.link/20250224111251.1061098-5-wei.fang@nxp.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Charles Xu <charles_xu@189.cn>
> ---
>  drivers/net/ethernet/freescale/enetc/enetc.c         | 3 +++
>  drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 8 ++++++--
>  2 files changed, 9 insertions(+), 2 deletions(-)

This breaks the build, ALWAYS test-build your patches.

thanks,

greg k-h

      reply	other threads:[~2026-04-13 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  3:23 [PATCH 6.1.y] net: enetc: VFs do not support HWTSTAMP_TX_ONESTEP_SYNC Charles Xu
2026-04-13 12:04 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026041329-recovery-disjoin-b370@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=charles_xu@189.cn \
    --cc=kuba@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=wei.fang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox