From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BFBF42A82 for ; Tue, 14 Apr 2026 00:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776125862; cv=none; b=J92pXUkp9P6ImhJLBFW1BjJeWWzh890wtOrfMg5oHQixIlLGpSAj8JHInyxQrAbzQk/q1u5de7WMxgvxpqAqYICi6URbkqVp8tN/TfXnlKcx2SvaMc3W4XQeA9suMiUrc6xltdVMocKhIyJu+JJpGabgo0A3yYyUllOxcpt6iwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776125862; c=relaxed/simple; bh=2KlkgseIEnmABBwFmdACXo8l3+yhBdCWpivMQKlouzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I98HRMAoYbSiZKVi7tfK17JJOuBmxdCXHiMnjL5sivWfiaHXelUFQIPXrvxLhGh6OtfLVyfFcI833pkElOHjCJuEgIZDcCgrDSkOy26h87EAIY7yuICl6fGtl2GGvj5HrcBMhGhi3+2Pngk3+ZQQQUwpjiGcXhOmBuegeC0oUgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kYUsuEs0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kYUsuEs0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E15B5C2BCAF; Tue, 14 Apr 2026 00:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776125861; bh=2KlkgseIEnmABBwFmdACXo8l3+yhBdCWpivMQKlouzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kYUsuEs0a3ucQevAoZ/sn8C6LTBJBvH64zH5Jot0mn0rTlMTb7m4lwUhrTff1fl13 N2zFuXqP+e9NCXoel4qMbUJQoz9lHlDkp430pWA8meUPRwJsZtxzIWUyVzy0KKPWIb CXtK5X5GIvGofm5kNpCyzS5nbZiJW6hIILA/+MoQRt1iCIOjsWVm2YcJgEIM03w/we 4MULzHNNHbO2G4dUPXA+w2dtOnK1sE8t6u91dDIFEDlU0Umo/w6YlbZkB/gZeCbruX Fv0/+/Z1PLNTJI8G0H8LbIUyj0ofG5+KPW5Kst+OEHb3Zka3lLj4utc+i5uxePvxeC hdNE+5q3UNvyA== From: Sasha Levin To: stable@vger.kernel.org Cc: David Howells , Marc Dionne , Jeffrey Altman , Simon Horman , linux-afs@lists.infradead.org, stable@kernel.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15.y] rxrpc: Fix key quota calculation for multitoken keys Date: Mon, 13 Apr 2026 20:17:39 -0400 Message-ID: <20260414001739.3796841-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026041336-pavestone-racing-acf1@gregkh> References: <2026041336-pavestone-racing-acf1@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Howells [ Upstream commit bdbfead6d38979475df0c2f4bad2b19394fe9bdc ] In the rxrpc key preparsing, every token extracted sets the proposed quota value, but for multitoken keys, this will overwrite the previous proposed quota, losing it. Fix this by adding to the proposed quota instead. Fixes: 8a7a3eb4ddbe ("KEYS: RxRPC: Use key preparsing") Closes: https://sashiko.dev/#/patchset/20260319150150.4189381-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Marc Dionne cc: Jeffrey Altman cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org Link: https://patch.msgid.link/20260408121252.2249051-2-dhowells@redhat.com Signed-off-by: Jakub Kicinski [ dropped hunk for rxrpc_preparse_xdr_yfs_rxgk() ] Signed-off-by: Sasha Levin --- net/rxrpc/key.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index 8d2073e0e3da5..e0e2bf7d5a1d5 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -72,7 +72,7 @@ static int rxrpc_preparse_xdr_rxkad(struct key_preparsed_payload *prep, return -EKEYREJECTED; plen = sizeof(*token) + sizeof(*token->kad) + tktlen; - prep->quotalen = datalen + plen; + prep->quotalen += datalen + plen; plen -= sizeof(*token); token = kzalloc(sizeof(*token), GFP_KERNEL); @@ -303,6 +303,7 @@ static int rxrpc_preparse(struct key_preparsed_payload *prep) memcpy(&kver, prep->data, sizeof(kver)); prep->data += sizeof(kver); prep->datalen -= sizeof(kver); + prep->quotalen = 0; _debug("KEY I/F VERSION: %u", kver); @@ -340,7 +341,7 @@ static int rxrpc_preparse(struct key_preparsed_payload *prep) goto error; plen = sizeof(*token->kad) + v1->ticket_length; - prep->quotalen = plen + sizeof(*token); + prep->quotalen += plen + sizeof(*token); ret = -ENOMEM; token = kzalloc(sizeof(*token), GFP_KERNEL); -- 2.53.0