From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B2C31F92E for ; Tue, 14 Apr 2026 01:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776129547; cv=none; b=OJep4AI+sbHiWzoLkAZ9TaLm+x04Vvt/yLPIQ76IP++MEhse8qmgGqvU4IDjsnEDIdoo2b9UnpKfhWDxRoAoRVJYTkEHNdiExJsmaXGQ2YVXTEvypgj8yw9zN3NA7vEFOofhUdxsPFLq527Ja2hnQrm4H7EZcNxZ/wONN6SANps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776129547; c=relaxed/simple; bh=Qwgu/i4hE/uex+/yo4TbxSU2WE1DOGlu7dUBkceoB94=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ce6vEkRJu/VUvQg6fshOCsKAwrXWC4KG9I6SBs9jzAOISI3JtdZ2hwkiCqvP/M3+dJCIwmJYjUjJ7aj+wK9A796/R6ihUzUMXzLIKv9jiratkzPqzi8Do6VUkarE8STtFWBVkthhGEWZgYpfep9weQFPWTNEgA0vsGAzj+z3RAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ovNRTZ06; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ovNRTZ06" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99121C2BCAF; Tue, 14 Apr 2026 01:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776129547; bh=Qwgu/i4hE/uex+/yo4TbxSU2WE1DOGlu7dUBkceoB94=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ovNRTZ065gc32u1h9PFat9jg/xrsIhFgSZnEbHQ0m8+OuquuRtdhUqAMJ7O/Wzf8H T7JND+Ty5/z6+z4gZgVd04eFk6QIiO8SAl7W94+5kJPhVveewfXsSOVuMPbgGQodZO y6mc3iBTA4tzosxp9uMOB5gmzVQ0Im2QjcMdyeUu6rhum1KYe1CXQ4gF0g2I7+TC2C s82RijrdjKDZ2IYTPHxAqmrN0FxAiKzInVDTk80a4FW0euOd2fMDx+HZvy1gOwfCds oIzVa56JgqiNJPwPcE8a78OuAZt8isTXJLizuNd12m7y0oV2VQaa4+pPqpWodvin9e Z4hEfs2v7noSA== From: Sasha Levin To: stable@vger.kernel.org Cc: Luxiao Xu , Yifan Wu , Juefei Pu , Yuan Tan , Xin Liu , Ren Wei , Ren Wei , David Howells , Marc Dionne , Simon Horman , linux-afs@lists.infradead.org, stable@kernel.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y] rxrpc: fix reference count leak in rxrpc_server_keyring() Date: Mon, 13 Apr 2026 21:19:03 -0400 Message-ID: <20260414011903.3831717-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026041355-flap-narrow-9fea@gregkh> References: <2026041355-flap-narrow-9fea@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luxiao Xu [ Upstream commit f125846ee79fcae537a964ce66494e96fa54a6de ] This patch fixes a reference count leak in rxrpc_server_keyring() by checking if rx->securities is already set. Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both") Reported-by: Yifan Wu Reported-by: Juefei Pu Co-developed-by: Yuan Tan Signed-off-by: Yuan Tan Suggested-by: Xin Liu Tested-by: Ren Wei Signed-off-by: Luxiao Xu Signed-off-by: Ren Wei Signed-off-by: David Howells cc: Marc Dionne cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org Link: https://patch.msgid.link/20260408121252.2249051-15-dhowells@redhat.com Signed-off-by: Jakub Kicinski [ applied patch to net/rxrpc/key.c instead of net/rxrpc/server_key.c ] Signed-off-by: Sasha Levin --- net/rxrpc/key.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index 979338a64c0ca..0144155d02e05 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -933,6 +933,9 @@ int rxrpc_server_keyring(struct rxrpc_sock *rx, sockptr_t optval, int optlen) _enter(""); + if (rx->securities) + return -EINVAL; + if (optlen <= 0 || optlen > PAGE_SIZE - 1) return -EINVAL; -- 2.53.0