From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A3D23016FC for ; Tue, 14 Apr 2026 11:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776165666; cv=none; b=B5gcPjRDr92W5Gi6MJIH0eJYnMWkcIq2u/6elNEQs4nOuPlJs29KU39v00WzxfCnit6MB7Xa8D/Omrj2tbcpTL+I8Yz7yhesrT9dOdxGawEX68GkbOqWZ9F4B9Fgen8xWASxsqxNKFFz4CflqYBDtNsekUO5B6wmEYZWWZ5RqO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776165666; c=relaxed/simple; bh=S1xiMOXB05lmC+GuY6qL04nw0k8EGBasgm8jXjBZ33E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WgKk37SQM7MO2Nh9SuWfKsBpkt5P2BmOFxeedH9Ig/NIh993RSXAvYIbDEmV9E/6be4Y86dDZY8ty+f0PLxlXb70c7DmD6g8gPbg+noQs9Ym71oYPDVJHzTdoRPZOLTgU17u/KKzuTYBoPSz1lQZUO9R/fAzqpXDlWHUDBzeZrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hRcLPUg/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hRcLPUg/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90D57C19425; Tue, 14 Apr 2026 11:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776165666; bh=S1xiMOXB05lmC+GuY6qL04nw0k8EGBasgm8jXjBZ33E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hRcLPUg/wOftcuds6kxI2ZTzil3DnPGYXwy+II7erX63sbLlt1EhrbivI3fl83h4g NB/isrigTSt2/Qwx2CYkYEgS32+/NpIBrcw8KrQqv7EpAkr6WX9YEDgCvplYf+8uJy QlYclbTACEvj1FRFJi6Uu45Q1uMYchKDddliBcYN104uWgyZR003irNydhlGxhubTB a6PHzbY+yrCm+NqAI7BHhb1ruSykQqbb8SsiGB7FcVWH0BPbRRHsjAayjIjlD8rRou QVW/7a+gM9uYoGGK1+4gvjy6FnnTK6tPctv/skAVeAI5mZo+5SX7zcXt02CYEBfCyw ekWkNn9UljBjQ== From: Sasha Levin To: stable@vger.kernel.org Cc: David Howells , Marc Dionne , linux-afs@lists.infradead.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12.y 1/2] rxrpc: Don't need barrier for ->tx_bottom and ->acks_hard_ack Date: Tue, 14 Apr 2026 07:21:02 -0400 Message-ID: <20260414112103.379483-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026041310-strung-among-c622@gregkh> References: <2026041310-strung-among-c622@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Howells [ Upstream commit 6396b48ac0a77165f9c2c40ab03d6c8188c89739 ] We don't need a barrier for the ->tx_bottom value (which indicates the lowest sequence still in the transmission queue) and the ->acks_hard_ack value (which tracks the DATA packets hard-ack'd by the latest ACK packet received and thus indicates which DATA packets can now be discarded) as the app thread doesn't use either value as a reference to memory to access. Rather, the app thread merely uses these as a guide to how much space is available in the transmission queue Change the code to use READ/WRITE_ONCE() instead. Also, change rxrpc_check_tx_space() to use the same value for tx_bottom throughout. Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org Link: https://patch.msgid.link/20241204074710.990092-18-dhowells@redhat.com Signed-off-by: Jakub Kicinski Stable-dep-of: c43ffdcfdbb5 ("rxrpc: only handle RESPONSE during service challenge") Signed-off-by: Sasha Levin --- net/rxrpc/sendmsg.c | 8 +++++--- net/rxrpc/txbuf.c | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index 154f650efb0ab..2f2c2fe739ffc 100644 --- a/net/rxrpc/sendmsg.c +++ b/net/rxrpc/sendmsg.c @@ -93,9 +93,11 @@ static int rxrpc_wait_to_be_connected(struct rxrpc_call *call, long *timeo) */ static bool rxrpc_check_tx_space(struct rxrpc_call *call, rxrpc_seq_t *_tx_win) { + rxrpc_seq_t tx_bottom = READ_ONCE(call->tx_bottom); + if (_tx_win) - *_tx_win = call->tx_bottom; - return call->tx_prepared - call->tx_bottom < 256; + *_tx_win = tx_bottom; + return call->tx_prepared - tx_bottom < 256; } /* @@ -137,7 +139,7 @@ static int rxrpc_wait_for_tx_window_waitall(struct rxrpc_sock *rx, rtt = 2; timeout = rtt; - tx_start = smp_load_acquire(&call->acks_hard_ack); + tx_start = READ_ONCE(call->acks_hard_ack); for (;;) { set_current_state(TASK_UNINTERRUPTIBLE); diff --git a/net/rxrpc/txbuf.c b/net/rxrpc/txbuf.c index c3913d8a50d34..a63e10fcd11c4 100644 --- a/net/rxrpc/txbuf.c +++ b/net/rxrpc/txbuf.c @@ -216,14 +216,14 @@ void rxrpc_shrink_call_tx_buffer(struct rxrpc_call *call) while ((txb = list_first_entry_or_null(&call->tx_buffer, struct rxrpc_txbuf, call_link))) { - hard_ack = smp_load_acquire(&call->acks_hard_ack); + hard_ack = call->acks_hard_ack; if (before(hard_ack, txb->seq)) break; if (txb->seq != call->tx_bottom + 1) rxrpc_see_txbuf(txb, rxrpc_txbuf_see_out_of_step); ASSERTCMP(txb->seq, ==, call->tx_bottom + 1); - smp_store_release(&call->tx_bottom, call->tx_bottom + 1); + WRITE_ONCE(call->tx_bottom, call->tx_bottom + 1); list_del_rcu(&txb->call_link); trace_rxrpc_txqueue(call, rxrpc_txqueue_dequeue); -- 2.53.0