From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C403E0C62 for ; Tue, 14 Apr 2026 11:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776167560; cv=none; b=UN1voiEfDfKu0dlspq/IhDYEUQIdAdZ7b0eqEAqq0o7oz6c0Om8ZbXiI1aYspqb2Ngg7Kax3RgEBQdmoDzs7x1h/24eNK2+UM2IrF1p3HNAPkODa7bb+KdGr+tmPoRE7GJVCfJKISK2efN5/kSkOMywpA1tsNpZZcsNqG6nXIBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776167560; c=relaxed/simple; bh=cwZOpMdP2qGEUDGYuXICLftRGcjtotCpcK4KLNj42M4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QvjOjSSYMLfMN9wZ3rL31Bw7zkcCRGCygql/ZJFDgekuLmmV9m++1hKfpqSxL3LcNzjH9HoT6JQVsh961Dg1pCa/jmVPLha7Gxd5f3cSjrGehPKmsGfJYSK0DbXvpEiX7gqdTghtCns6xHfn63cr01ooRR0yvtDxkWY7BkN9dgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tE+4pY0c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tE+4pY0c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FF8CC19425; Tue, 14 Apr 2026 11:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776167560; bh=cwZOpMdP2qGEUDGYuXICLftRGcjtotCpcK4KLNj42M4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tE+4pY0c7XQeOZtDzpUneWDN39Z26T1LB+ms81OEC0Tkd+HQOuzVzxc5nawKrxU5z P4vZFrz2eZhfzChV88TClw0Y4VHetWEMm7JA5TrgEc3VhpzuLQq1CuG8syHLnDDIu9 BiOUO3TBJPNi7+XNw+GZvdBH7hNuojYRSzxrlYXN8Ru6k32TKB2RhyNoeyK8ynY2mP dNgqiHXecMqxS53DcfNvyzpg3LOXtsonuxeyw3ALBw4lRdQEU3nhIa9IAhvWUD/VhZ GdkHpooP61U3dvxbkIKNWZXEhogmRghuEI+zkrq+1/kKttByZnmrwJKINNwU5IZZBO D6l/pqQR6czLA== From: Sasha Levin To: stable@vger.kernel.org Cc: Yuqi Xu , Yifan Wu , Juefei Pu , Yuan Tan , Xin Liu , Ren Wei , Ren Wei , David Howells , Marc Dionne , Simon Horman , linux-afs@lists.infradead.org, stable@kernel.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1.y] rxrpc: reject undecryptable rxkad response tickets Date: Tue, 14 Apr 2026 07:52:36 -0400 Message-ID: <20260414115236.537968-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026041318-resource-luckless-1cf9@gregkh> References: <2026041318-resource-luckless-1cf9@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Yuqi Xu [ Upstream commit fe4447cd95623b1cfacc15f280aab73a6d7340b2 ] rxkad_decrypt_ticket() decrypts the RXKAD response ticket and then parses the buffer as plaintext without checking whether crypto_skcipher_decrypt() succeeded. A malformed RESPONSE can therefore use a non-block-aligned ticket length, make the decrypt operation fail, and still drive the ticket parser with attacker-controlled bytes. Check the decrypt result and abort the connection with RXKADBADTICKET when ticket decryption fails. Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both") Reported-by: Yifan Wu Reported-by: Juefei Pu Co-developed-by: Yuan Tan Signed-off-by: Yuan Tan Suggested-by: Xin Liu Tested-by: Ren Wei Signed-off-by: Yuqi Xu Signed-off-by: Ren Wei Signed-off-by: David Howells cc: Marc Dionne cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org Link: https://patch.msgid.link/20260408121252.2249051-12-dhowells@redhat.com Signed-off-by: Jakub Kicinski [ adapted `rxrpc_abort_conn()` call to existing `goto other_error` error-handling pattern ] Signed-off-by: Sasha Levin --- net/rxrpc/rxkad.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 78fa0524156f1..84a61fa18bc06 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -1013,8 +1013,13 @@ static int rxkad_decrypt_ticket(struct rxrpc_connection *conn, sg_init_one(&sg[0], ticket, ticket_len); skcipher_request_set_callback(req, 0, NULL, NULL); skcipher_request_set_crypt(req, sg, sg, ticket_len, iv.x); - crypto_skcipher_decrypt(req); + ret = crypto_skcipher_decrypt(req); skcipher_request_free(req); + if (ret < 0) { + abort_code = RXKADBADTICKET; + ret = -EPROTO; + goto other_error; + } p = ticket; end = p + ticket_len; -- 2.53.0