From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B42396D28 for ; Tue, 14 Apr 2026 12:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776168317; cv=none; b=fXQNE/LNaaMV2bz6YGxDf+kRDXaHHp8leUGTnW77q1t9GVzGWayVaud2x8NSo0D7RMiZ5BMON4ywcphXbjYOOoWVk2hOdGncZ0JnNhf8dTWj0pP2AfsbTcGvExB5/dW284pbeRRN8Rl4DgjfxTF16Dlb45UE/QhFB0P8awWyt28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776168317; c=relaxed/simple; bh=H4/8UGbA8YbjMZmG1RBfjwwqScPHQ44flBhxvC4tpF4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=epaXwGozYItmWK+OsgoOKEwF2hO5G5Mh1WPcS/3ntIdnZv5fFoo7/v/1fY53SmfeKnYHhYMm5AbkOV60u3cbqYWE+XIGrx0RZDrAoJ8Q9i0Co+ci1mdEIWT1F5LeKdDge3QAKpdqO80WWidhU5zsKMpxojNfUhdWCmQydH4vWb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=umaiYaXs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="umaiYaXs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02451C19425; Tue, 14 Apr 2026 12:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776168317; bh=H4/8UGbA8YbjMZmG1RBfjwwqScPHQ44flBhxvC4tpF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=umaiYaXskkpOzVlNlpPHkmLVOCrJ0Q+ppX4896U5U1sdPM6YGvE011EbHON0tqp5E L5MoSZHASeSAiowqqNAoSk2BhTDvjluZVXN2ynmBB11rscSQ/87SS5ivyej63zYpiR hfurFlJRVuLQZiLsmTNeJr9o2D725qff6Qj5pUheB8beBJdmtVSABDU4SV1DTieLMb Mc5WomkQzqXhU0RU/McH+HQBvDvXw2Lz0IBXUX3dsHTXvphdNa+bOukQG6JAeefUtq PxaMFjUP+5QqgjnJURwMdRjMECsBw2JplaMVI/0hxHGxfRMWCdelfxgwHqOo/uRGLI WTW2J4Ly0V1nA== From: Sasha Levin To: stable@vger.kernel.org Cc: Yuqi Xu , Yifan Wu , Juefei Pu , Yuan Tan , Xin Liu , Ren Wei , Ren Wei , David Howells , Marc Dionne , Simon Horman , linux-afs@lists.infradead.org, stable@kernel.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y] rxrpc: reject undecryptable rxkad response tickets Date: Tue, 14 Apr 2026 08:05:14 -0400 Message-ID: <20260414120514.569478-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026041319-rejoicing-drainpipe-edb3@gregkh> References: <2026041319-rejoicing-drainpipe-edb3@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Yuqi Xu [ Upstream commit fe4447cd95623b1cfacc15f280aab73a6d7340b2 ] rxkad_decrypt_ticket() decrypts the RXKAD response ticket and then parses the buffer as plaintext without checking whether crypto_skcipher_decrypt() succeeded. A malformed RESPONSE can therefore use a non-block-aligned ticket length, make the decrypt operation fail, and still drive the ticket parser with attacker-controlled bytes. Check the decrypt result and abort the connection with RXKADBADTICKET when ticket decryption fails. Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both") Reported-by: Yifan Wu Reported-by: Juefei Pu Co-developed-by: Yuan Tan Signed-off-by: Yuan Tan Suggested-by: Xin Liu Tested-by: Ren Wei Signed-off-by: Yuqi Xu Signed-off-by: Ren Wei Signed-off-by: David Howells cc: Marc Dionne cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org Link: https://patch.msgid.link/20260408121252.2249051-12-dhowells@redhat.com Signed-off-by: Jakub Kicinski [ adapted `rxrpc_abort_conn()` call to existing `goto other_error` error-handling pattern ] Signed-off-by: Sasha Levin --- net/rxrpc/rxkad.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 5345e8eefd33c..c9966722dcf78 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -941,8 +941,13 @@ static int rxkad_decrypt_ticket(struct rxrpc_connection *conn, sg_init_one(&sg[0], ticket, ticket_len); skcipher_request_set_callback(req, 0, NULL, NULL); skcipher_request_set_crypt(req, sg, sg, ticket_len, iv.x); - crypto_skcipher_decrypt(req); + ret = crypto_skcipher_decrypt(req); skcipher_request_free(req); + if (ret < 0) { + abort_code = RXKADBADTICKET; + ret = -EPROTO; + goto other_error; + } p = ticket; end = p + ticket_len; -- 2.53.0