From: "Pradhan, Sanman" <sanman.pradhan@hpe.com>
To: "yangyicong@hisilicon.com" <yangyicong@hisilicon.com>,
"jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>
Cc: "alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"yangyccccc@gmail.com" <yangyccccc@gmail.com>,
Sanman Pradhan <psanman@juniper.net>
Subject: [PATCH v2 2/2] hwtracing: hisi_ptt: Remove unnecessary trace buffer zeroing in trace_start()
Date: Tue, 14 Apr 2026 17:25:22 +0000 [thread overview]
Message-ID: <20260414172451.14331-3-sanman.pradhan@hpe.com> (raw)
In-Reply-To: <20260414172451.14331-1-sanman.pradhan@hpe.com>
From: Sanman Pradhan <psanman@juniper.net>
hisi_ptt_trace_start() clears all four trace buffers before enabling
tracing.
This is unnecessary. On trace stop, hisi_ptt_update_aux() copies only
the number of bytes reported in HISI_PTT_TRACE_WR_STS. On buffer-full
interrupts, it copies a full completed buffer. In both cases the driver
only consumes data written by hardware.
Remove the buffer clearing from the trace start path.
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Reviewed-by: Yicong Yang <yangyccccc@gmail.com>
---
v2:
- No changes
drivers/hwtracing/ptt/hisi_ptt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
index b5d851281fbf0..a8f6986c8e1f7 100644
--- a/drivers/hwtracing/ptt/hisi_ptt.c
+++ b/drivers/hwtracing/ptt/hisi_ptt.c
@@ -194,7 +194,6 @@ static int hisi_ptt_trace_start(struct hisi_ptt *hisi_ptt)
{
struct hisi_ptt_trace_ctrl *ctrl = &hisi_ptt->trace_ctrl;
u32 val;
- int i;
/* Check device idle before start trace */
if (!hisi_ptt_wait_trace_hw_idle(hisi_ptt)) {
@@ -222,10 +221,6 @@ static int hisi_ptt_trace_start(struct hisi_ptt *hisi_ptt)
/* Reset the index of current buffer */
hisi_ptt->trace_ctrl.buf_index = 0;
- /* Zero the trace buffers */
- for (i = 0; i < HISI_PTT_TRACE_BUF_CNT; i++)
- memset(ctrl->trace_buf[i].addr, 0, HISI_PTT_TRACE_BUF_SIZE);
-
/* Clear the interrupt status */
writel(HISI_PTT_TRACE_INT_STAT_MASK, hisi_ptt->iobase + HISI_PTT_TRACE_INT_STAT);
writel(0, hisi_ptt->iobase + HISI_PTT_TRACE_INT_MASK);
--
2.34.1
next prev parent reply other threads:[~2026-04-14 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 17:25 [PATCH v2 0/2] hwtracing: hisi_ptt: Fix reset timeout handling and clean up trace start Pradhan, Sanman
2026-04-14 17:25 ` [PATCH v2 1/2] hwtracing: hisi_ptt: Propagate DMA reset timeout in trace_start() Pradhan, Sanman
2026-04-16 17:25 ` Yicong Yang
2026-04-20 7:32 ` Sizhe Liu
2026-04-14 17:25 ` Pradhan, Sanman [this message]
2026-04-17 12:45 ` [PATCH v2 0/2] hwtracing: hisi_ptt: Fix reset timeout handling and clean up trace start Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414172451.14331-3-sanman.pradhan@hpe.com \
--to=sanman.pradhan@hpe.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=psanman@juniper.net \
--cc=stable@vger.kernel.org \
--cc=yangyccccc@gmail.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox