From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465A03CF023 for ; Wed, 15 Apr 2026 13:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261443; cv=none; b=tKZEkwK9wYxVHU1yuUQbZvYpTkSjpCF40y/gZM08c5oByJf4b6TsigDQMDBtA5Bc7/MuigJyABbPJgbc5b69+vT6JC30NLRNTtDS8okCtF/FiW5HVWHPMqqmyFWfnAwraJLfOIhF5cGHutr3NqRr3P19HACs0NXBJ1kj2Be1Fxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261443; c=relaxed/simple; bh=kR6XaPPhqk7/FZfm+7Lrh4cNqr8IqR1rG7bYGB+SH4o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tmpqN+ZJp6YGWiP6/xmxVtAUOFcIy/VGn9/cfrmXwWeGp6GCrPshQHtAVSTjkEcqq2njGnTV6/3o/lguQ21JvQYwv+2AukMEPxtKdZgDW3/jw3hyj06NLqNIdr2LqHVgrCTQR9RrvchWKnUkL4jozxI2cehnrJ4yg5tSpFDt7cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PBKjw9P0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PBKjw9P0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7BAC19424; Wed, 15 Apr 2026 13:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776261443; bh=kR6XaPPhqk7/FZfm+7Lrh4cNqr8IqR1rG7bYGB+SH4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PBKjw9P0D3Yo/nvGtf4WPYh6j4CqXiH23IeCOLT8wT2v5u4Q8AGdq4gtZmceZXadL N/B2dEu2nMt9Rag30PV5wCS5baXGwo6bLrBblELe/O42JVr2f6mv5U3DFoTeHknvNZ s0czrxN5B5T31B34SOOz+qSblmPOsKvKc7hMR8JgwAQlWviIJvKL8OqNYuTqZhK3lN Eq+ZTWw4PU9M9FwKtpLXDoIjmGJ4eoUmdqbJkcOxHABlGV2nZuP2K91h3NVKS9mWXX FK74QosMC4K60dVKxSi04qHe6V6xnnlMrP2G2sucO1qjdkxK8eB2XMf7a19tl5mI4a 7xackfAJwx67w== From: Sasha Levin To: Ben Hutchings Cc: Sasha Levin , stable@vger.kernel.org, Greg Kroah-Hartman , Marc Kleine-Budde Subject: Re: [PATCH 5.10 191/491] can: gs_usb: gs_can_open(): always configure bitrates before starting device Date: Wed, 15 Apr 2026 09:57:21 -0400 Message-ID: <20260415160001.gs-usb-keep@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <9e1d8d13f872acab49ac25ccf6d18b3a2698d421.camel@decadent.org.uk> References: <20260413155819.042779211@linuxfoundation.org> <20260413155826.219285216@linuxfoundation.org> <9e1d8d13f872acab49ac25ccf6d18b3a2698d421.camel@decadent.org.uk> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > This error path leaks the URBs allocated above (but the upstream version > does not have this problem). > > I think it would make sense to backport commit 2603be9e8167 ("can: > gs_usb: gs_can_open(): improve error handling") before this one. Good catch. Since this is a small leak on a rare failure path, and the pre-existing error paths in gs_can_open() already had similar issues, I'll keep it in the 5.10 queue for this release. I'll plan to backport 2603be9e8167 for the next cycle, which will fix all the error paths properly.